PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar svanschu
svanschu
21 Oct 2023

In this method it tries to load the field 'id' from the extensions table. But there isn't any field called id in this table. The id field for the extenions table is called extension_id

Pull Request for Issue #42191 .

Summary of Changes

Moved the select id statement into the module if clause and create a new select extension_id as id clause for the else branch

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar svanschu svanschu - open - 21 Oct 2023
avatar svanschu svanschu - change - 21 Oct 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 21 Oct 2023
Category Libraries
avatar svanschu svanschu - change - 21 Oct 2023
The description was changed
avatar svanschu svanschu - edited - 21 Oct 2023
avatar svanschu svanschu - change - 21 Oct 2023
Labels Added: PR-5.0-dev
avatar richard67
richard67 - comment - 22 Oct 2023

@svanschu As far as I could see we have the same error also in the 4.4-dev code at the same place. Is that right? If so, the PR should be made for the 4.4-dev branch. When that PR will be merged, maintainers will sooner or later merge it up to 5.0-dev, so the bug will be fixed in 4.4.1 and 5.0.1.

avatar svanschu
svanschu - comment - 22 Oct 2023

@svanschu As far as I could see we have the same error also in the 4.4-dev code at the same place. Is that right? If so, the PR should be made for the 4.4-dev branch. When that PR will be merged, maintainers will sooner or later merge it up to 5.0-dev, so the bug will be fixed in 4.4.1 and 5.0.1.

Yes 4.4 ist identical to 5.0 in this code section.

Then I will create a new PR for 4.4 and close this one when it's opened.

avatar svanschu
svanschu - comment - 22 Oct 2023

@richard67 PR for 4.4-dev is created #42199

Closing this one

avatar svanschu svanschu - change - 22 Oct 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-10-22 14:18:25
Closed_By svanschu
avatar svanschu svanschu - close - 22 Oct 2023

Add a Comment

Login with GitHub to post a comment