Joomla! Issue Tracker | Joomla! CMS #42173 - [5.0] php notice in cli installation

PR-5.0-dev

Closed
19 Oct 2023
Medium
Build: 5.0-dev
# 42173
Diff
brianteeman:phjp_notice

Pending

User tests: Successful: Unsuccessful:

brianteeman
19 Oct 2023

do not test yet please. this is just so I can get an install to test

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed

bb2cb20 19 Oct 2023

[5.0] php notice in cli installation

brianteeman - open - 19 Oct 2023

brianteeman - change - 19 Oct 2023

Status

New

⇒

Pending

joomla-cms-bot - change - 19 Oct 2023

Category

⇒

Front End Plugins

Fedik - comment - 19 Oct 2023

It not an issue for 5.0 but for 4.4,
If you want to fix it, then have to do it similar to how it done in other places:

joomla-cms/plugins/content/fields/services/provider.php

Lines 35 to 39 in 1e7527b

    
           $dispatcher = $container->get(DispatcherInterface::class); 
        
           $plugin     = new Fields( 
        
               $dispatcher, 
        
               (array) PluginHelper::getPlugin('content', 'fields') 
        
           );

Note: the $dispatcher made as variable.

brianteeman - comment - 19 Oct 2023

yes I already did that but wasn't able to successfully test it. will try again shortly

brianteeman - comment - 19 Oct 2023

in 4.4 it is using $dispatcher as you suggest
in 5.0 it was changed by @laoneo in #40746

beyond my knowledge - will close this and update the issue report

brianteeman - close - 19 Oct 2023