Feeling Lucky
?
bug
PR-5.0-dev
[#42168] - [5.0] Add proper error handling for public folder cli installation
- Fixed in Code Base
- 20 Oct 2023
- Medium
- Build: 5.0-dev
- # 42168
- Diff
- HLeithner:5.0/fix/publicfoldercliinstall
User tests: Successful: Unsuccessful:
Summary of Changes
PublicFolderGeneratorHelper::createPublicFolder() returns void but throw exception
Testing Instructions
Install with cli and public folder
Actual result BEFORE applying this Pull Request
Execution stops after
Creating the public folder... (no new line)
reason for this is createPublicFolder() returns void which converts to false and ends with Command::FAILURE you Don't get a success message
Expected result AFTER applying this Pull Request
You get a success message after cli installation with public folder.
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Installation |
bembelimen
- comment
- 20 Oct 2023
I have tested this item ✅ successfully on 0c5a204
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42168.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
bug
PR-5.0-dev
|
||
Quy
- comment
- 20 Oct 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42168.
| Labels |
Added:
?
|
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-20 08:20:10 |
| Closed_By | ⇒ | richard67 |
richard67
- comment
- 20 Oct 2023
Thanks.
I have tested this item ✅ successfully on 0c5a204
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42168.