[#42166] - [5.1] Cleanup input options
- Fixed in Code Base
- 8 Nov 2023
- Medium
- Build: 5.0-dev
- # 42166
- Diff
- wilsonge:cleanup/cli-options
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
When the live site parameter was added for some reason rather than adding just that parameter into the existing definition we re-created the entire definition
Testing Instructions
Check all global options are still available when using the CLI (such as verbosity and the live site parameter). There should be no changes but less code (yay!)
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Title |
|
||||||
rebased it to 5.1 because it's not a bug that needs to be fixed, it's an improvement
conflict's will be solved by upmerging 5.0 to 5.1 soon
| Labels |
Added:
Feature
PR-5.0-dev
|
||
| Category | Libraries | ⇒ | Administration com_fields com_installer com_joomlaupdate com_media NPM Change com_messages Language & Strings Repository Installation Libraries |
| Labels |
Added:
Language Change
NPM Resource Changed
PR-5.1-dev
|
||
| Category | Libraries Administration com_fields com_installer com_joomlaupdate com_media NPM Change com_messages Language & Strings Repository Installation | ⇒ | Libraries |
I have tested this item ✅ successfully on 4e2c60a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42166.
I have tested this item ✅ successfully on 4e2c60a
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42166.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42166.
| Labels |
Added:
?
|
||
| Labels |
Added:
?
Removed: ? Language Change NPM Resource Changed PR-5.0-dev |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-11-08 18:12:30 |
| Closed_By | ⇒ | LadySolveig | |
| Labels |
Added:
?
Removed: ? |
||
Remove the
use Symfony\Component\Console\Input\InputArgument;in line 57 because it became obsolete with the other changes, that's why PHPCS fails in drone (new rule for unnecessary use statements).