No Code Attached Yet bug
avatar dautrich
dautrich
18 Oct 2023

Steps to reproduce the issue

  1. Update a Joomla 4.3.4 installation to Joomla 4.4.0
  2. Look into the User Action Log

Expected result

There is a message "User xxx updated Joomla from 4.3.4 to 4.4.0"

Actual result

Before the correct message, an additional message is thrown: "User xxx updated Joomla from Unknown to 4.4.0"

grafik

System information (as much as possible)

Joomla 4.4.0
PHP 8.2.2
MySQL 8.0.33

Additional comments

avatar dautrich dautrich - open - 18 Oct 2023
avatar joomla-cms-bot joomla-cms-bot - change - 18 Oct 2023
Labels Added: No Code Attached Yet
avatar joomla-cms-bot joomla-cms-bot - labeled - 18 Oct 2023
avatar brianteeman
brianteeman - comment - 18 Oct 2023

Confirmed

image

avatar Quy Quy - change - 18 Oct 2023
Labels Added: bug
avatar Quy Quy - labeled - 18 Oct 2023
avatar dautrich
dautrich - comment - 22 Apr 2024

I have changed the title of the issue because it still applies to Joomla 5.1 as well as to the previous versions:

grafik

avatar dautrich dautrich - change - 22 Apr 2024
Title
[4.4.0] Bad message in User Action Log on Joomla update
[5.1 Bad message in User Action Log on Joomla update
avatar dautrich dautrich - edited - 22 Apr 2024
avatar dautrich dautrich - change - 22 Apr 2024
Title
[5.1 Bad message in User Action Log on Joomla update
[5.1] Bad message in User Action Log on Joomla update
avatar dautrich dautrich - edited - 22 Apr 2024
avatar Fedik
Fedik - comment - 9 Jun 2024

This happens because the event onJoomlaAfterUpdate triggered twice in UpdateModel.
First time without version

$app->triggerEvent('onJoomlaAfterUpdate');

And then again but with version
$app->triggerEvent('onJoomlaAfterUpdate', [$oldVersion]);

And the action log store log for both.

The first trigger should be removed, however I am not sure what backward compatibility effect it can have on 3rd plugins.

It for ALL Joomla versions: 3.x, 4.x, 5.x

avatar HLeithner
HLeithner - comment - 10 Jun 2024

Hmm should be ok to remove the first one. Only the user state file is deleted before the second event is called, don't know if this is/should be used by 3rd party at all.

Add a Comment

Login with GitHub to post a comment