User tests: Successful: Unsuccessful:
Pull Request for Issue #42123 .
This change is to fix Joomla router unable to parse custom SEF url. The SEF url has a rewrite rule defined in .htaccess. where the SEF url need to be converted to dynamic url with query string.
The affected function is Uri::getInstance() in libraries/src/Uri directory.
q=xyz&dir=abc&name=ijk
The browser url will look like http://localhost/foo-menu/xyz/abc/ijk.html
In .htaccess, add re-write rule below
RewriteRule ^foo-menu/(.)/(.)/(.*).html$ index.php/foo-menu?q=$1&dir=$2&name=$3 [NC,L]
http://localhost/foo-menu?q=xyz&dir=abc&name=ijk
The .htaccess rewrite rule is not applied prior to calling Joomla's router. A custom router is required.
The rewrite rule in the ,htaccess is the custom router, dynamic url is generated before calling Joomla router. No extra custom router is needed.
Please select:
Documentation link for docs.joomla.org:
[x ] No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
[ x] No documentation changes for manual.joomla.org needed
Code changes have been uploaded as "Uri.txt" in the issue tracker at https://issues.joomla.org/tracker/joomla-cms/42123
Status | New | ⇒ | Pending |
Category | ⇒ | Libraries |
Labels |
Added:
PR-4.4-dev
|
Failure was due to "else if". It should be "elseif"...
Look like this checkin is going to 4.4-dev. Will it automatically propagates to later version, such as 5.x?
I am totally new to github...
Merged.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-18 09:58:05 |
Closed_By | ⇒ | vicn1222 |
Tests have been done in J3 & J4 multiple times. I am just unsure if I made the right pull request. This is the first time I am using github. So please correct me if there is any error in the pull request. I have been using svn all the time.
The change should also be applied to J3 if there is any possibility.
Thank you for the wonderful project!
-Frank