[#42135] - [5.0] Rework the com_messages message view
- Fixed in Code Base
- 18 Oct 2023
- Medium
- Build: 5.0-dev
- # 42135
- Diff
- wilsonge:rework/messages-html
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #42124 .
Summary of Changes
Rework of the HTML structure towards something geared towards more input'less elements. Physically separates the invisible form from the rendered HTML content.
Testing Instructions
Whilst this ensures the view looks better in dark mode. It obviously changes the structure in light mode too. This too should be validated. Check with longer and shorter message lengths.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_messages |
I have tested this item ✅ successfully on 93a717f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42135.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
PR-5.0-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42135.
| Labels |
Added:
?
|
||
If we want to treat this like a form field we should use formal input fields with labels as @dgrammatiko mentioned, close this PR and once #42124 is amended merge that one
If we’re happy rendering this without form field style rendering we should merge this PR and maintainers or a release lead should decide which approach
FWIW I'm in favour of this one
| Title |
|
||||||
| Category | Administration com_messages | ⇒ | Administration com_content com_joomlaupdate com_menus com_messages Language & Strings JavaScript Repository NPM Change Libraries |
@HLeithner Why not v5.0.1 as it is unreadable as of now in dark mode?
because the screenshots looks like only refactorying the html and no dark mode fixes
the html has to be refactored to enable the appropriate dark mode changes
| Title |
|
||||||
| Category | Administration com_messages com_content com_joomlaupdate com_menus Language & Strings JavaScript Repository NPM Change Libraries | ⇒ | Administration com_messages |
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-18 15:23:30 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
PR-5.1-dev
|
||
thanks
I have tested this item ✅ successfully on 93a717f
Tested successfully in 5.0.0-rc3-dev of 14 October using PHP 8.2.11 in Wampserver 3.3.1, in Light mode and Dark mode in Chrome.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42135.