Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42119] - [5.0] Media manager list view parity

? NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
11 Oct 2023

Pull Request for Issue #42101 .

Problem

  • SVG images inserted using the list view have zero width/height

Summary of Changes

  • The list view doesn't have the same data as the thumbnail view. SVG files need to be rendered to get the naturalHeight/naturalWidth
  • The selected item styling for the List view now applies the background colour to the whole row:
Screenshot 2023-10-11 at 21 59 09

Testing Instructions

  • Try to insert an svg into the intro image FROM THE LIST VIEW
  • Observe that the width and height parts at the end of the URL are not 0

Actual result BEFORE applying this Pull Request

Selecting an SVG image either from Grid view or List view DOESN'T yield the same URL

Expected result AFTER applying this Pull Request

Selecting an SVG image either from Grid view or List view should yield the same URL

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed

@laoneo

avatar dgrammatiko dgrammatiko - open - 11 Oct 2023
avatar dgrammatiko dgrammatiko - change - 11 Oct 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 11 Oct 2023
Category ⇒ Administration com_media NPM Change
avatar dgrammatiko dgrammatiko - change - 11 Oct 2023
The description was changed
avatar dgrammatiko dgrammatiko - edited - 11 Oct 2023
avatar dgrammatiko dgrammatiko - change - 11 Oct 2023
Labels Added: NPM Resource Changed PR-5.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 11 Oct 2023
Category Administration com_media NPM Change ⇒ Administration com_media NPM Change Repository
8a75743 11 Oct 2023 avatar dgrammatiko wip
avatar dgrammatiko dgrammatiko - change - 11 Oct 2023
Title
…
[5.0][WIP] Media manager list view parity
[5.0] Media manager list view parity
avatar dgrammatiko dgrammatiko - edited - 11 Oct 2023
avatar dgrammatiko dgrammatiko - change - 11 Oct 2023
The description was changed
avatar dgrammatiko dgrammatiko - edited - 11 Oct 2023
avatar ceford ceford - test_item - 13 Oct 2023 - Tested successfully
avatar ceford
ceford - comment - 13 Oct 2023

I have tested this item ✅ successfully on 8a75743

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42119.

avatar viocassel viocassel - test_item - 13 Oct 2023 - Tested successfully
avatar viocassel
viocassel - comment - 13 Oct 2023

I have tested this item ✅ successfully on 8a75743

?

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42119.

avatar alikon alikon - change - 13 Oct 2023
Status Pending ⇒ Ready to Commit
avatar alikon
alikon - comment - 13 Oct 2023

RTC

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42119.

avatar HLeithner HLeithner - change - 17 Oct 2023
Status Ready to Commit ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-10-17 20:09:27
Closed_By ⇒ HLeithner
Labels Added: ?
avatar HLeithner HLeithner - close - 17 Oct 2023
avatar HLeithner HLeithner - merge - 17 Oct 2023
avatar HLeithner
HLeithner - comment - 17 Oct 2023

thanks

Add a Comment

Login with GitHub to post a comment