[#42111] - Custom Fields: Add warning to Finder option about information disclosure
- Fixed in Code Base
- 17 Oct 2023
- Medium
- Build: 5.0-dev
- # 42111
- Diff
- Hackwar:5.0-finder-warning
User tests: Successful: Unsuccessful:
Pull Request for Issue #42076 .
Summary of Changes
5.0 comes with the new feature that you can index the value from a custom field to a content item. Due to structural limitations, this value is indexed with the same viewing permissions as the content item it is attached to. If your custom field is more restrictive than the viewing level of the content item, this might lead to unwanted information disclosure. It is NOT possible to prevent this in code, so this PR adds a warning label to the option to make people aware of this.
Testing Instructions
Codereview?
Actual result BEFORE applying this Pull Request
No warning below the "Search Index" option in a custom field.
Expected result AFTER applying this Pull Request
Warning below the "Search Index" option.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_fields Language & Strings |
I have tested this item ✅ successfully on a9fb331
I applied the patch and looked at the New Field / Options / Smart Search item - the warning is there and seems fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42111.
I have tested this item ✅ successfully on a9fb331
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42111.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
Language Change
PR-5.0-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42111.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-17 20:14:03 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
thanks
Message is shown, it would be good to display it as an alert warning (orange)