? Failure

User tests: Successful: Unsuccessful:

avatar beat
beat
3 Sep 2014

Executive summary

  1. Error message for maximum upload size is not hinting exact origin of problem nor how to fix the issue.
  2. Recommended maximum upload size is 4 MB, which is smaller than most major components.
  3. Error messages for upload size and post size wrongly indicate 2 MB instead of 4 MB now and are fixed to 8 MB with this PR too.

This PR is independent of #4209 , but is a useful addition.

Backwards compatibility

No backwards compatibility issues are introduced.

Translation impact

No translation strings are added or deleted, but 2 strings are updated to be more precise.

Testing instructions

Apply #4209

Test 1: Make sure that your server's php.ini has a max_upload_size of 1M. Try installing an extension bigger than that, e.g. Admin Tools Core, K2, Community Builder etc. You get a generic upload error. Apply the PR and retry. You now get an error telling you that the upload failed and that your maximum upload limit is too small.

Test 2: Go to Extensions / Extensions Manager and click Warnings on side-bar. You should see the updated message and limit too.

avatar beat beat - open - 3 Sep 2014
avatar jissues-bot jissues-bot - change - 3 Sep 2014
Labels Added: ?
avatar infograf768 infograf768 - change - 3 Sep 2014
Labels Added: ?
avatar infograf768
infograf768 - comment - 3 Sep 2014

Agree with this.
@test OK

avatar brianteeman
brianteeman - comment - 3 Sep 2014

interesting that the error message previously said <2mb when the code was checking for 4mb

avatar zero-24 zero-24 - change - 3 Sep 2014
Status New Pending
avatar phproberto phproberto - change - 3 Sep 2014
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2014-09-03 22:48:56
avatar phproberto phproberto - close - 3 Sep 2014
avatar phproberto phproberto - close - 3 Sep 2014
avatar phproberto
phproberto - comment - 3 Sep 2014

Merged. Thanks!!

Add a Comment

Login with GitHub to post a comment