Release Blocker bug PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
9 Oct 2023

Pull Request for Issue #42087 .

Summary of Changes

The language association value stored as id:alias, however in j4 it was cast to int

that was not obvious change, but that affects evrything.
I have made it a bit more explicit in the afected fields

Testing Instructions

Please follow #42087

Actual result BEFORE applying this Pull Request

An error

Expected result AFTER applying this Pull Request

No error

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed

Reference:

avatar Fedik Fedik - open - 9 Oct 2023
avatar Fedik Fedik - change - 9 Oct 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 9 Oct 2023
Category Administration com_content com_menus
avatar Fedik Fedik - change - 9 Oct 2023
The description was changed
avatar Fedik Fedik - edited - 9 Oct 2023
avatar alikon alikon - test_item - 9 Oct 2023 - Tested successfully
avatar alikon
alikon - comment - 9 Oct 2023

I have tested this item ✅ successfully on 45f33d2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42096.

avatar chmst chmst - test_item - 9 Oct 2023 - Tested successfully
avatar chmst
chmst - comment - 9 Oct 2023

I have tested this item ✅ successfully on 45f33d2


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42096.

avatar bembelimen bembelimen - change - 9 Oct 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-10-09 10:52:19
Closed_By bembelimen
Labels Added: Release Blocker bug PR-5.0-dev
avatar bembelimen bembelimen - close - 9 Oct 2023
avatar bembelimen bembelimen - merge - 9 Oct 2023
avatar bembelimen
bembelimen - comment - 9 Oct 2023

Thank you for the PR and the tests.

avatar richard67
richard67 - comment - 9 Oct 2023

I just wanted to mark my successful test result, but you were faster :-)

I've tested the side-by-side views (associations) for menu items as well, and also for not associated articles and menu items, all that works.

What remains is the issue I have commented here #42087 (comment) , that the "Clear" button doesn't do anything in the associations side-by-side view. I will later created a new issue for that (if there is none yet).

avatar chmst
chmst - comment - 9 Oct 2023

grafik

Got this error for the Clear button

avatar Fedik
Fedik - comment - 9 Oct 2023

I made PR for Clear button #42098

Add a Comment

Login with GitHub to post a comment