[#42085] - [5.0] Dark Mode: MFA button
- Fixed in Code Base
- 9 Oct 2023
- Medium
- Build: 5.0-dev
- # 42085
- Diff
- Quy:41794-mfa
User tests: Successful: Unsuccessful:
Partial Pull Request for Issue #41794.
Summary of Changes
Don't use outline button in order to be visible in dark mode.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Administration com_users |
Don't know if it matters or not but this changes the button to solid from an outline button in light and dark mode
It should be fine as it has the same style as here:
| Title |
|
||||||
We probably do need to fix the outline color to match what the main button is. However it also doesn’t hurt to unify the styling across core (if we aren’t using the outline class elsewhere)
rc2 is coming soon, which marks the end of non critical PRs.
| Labels |
Added:
PR-5.0-dev
Dark Mode
|
||
I have tested this item ✅ successfully on dae9e0f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42085.
I have not tested this item.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42085.
I have tested this item ✅ successfully on dae9e0f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42085.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42085.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-09 09:40:13 |
| Closed_By | ⇒ | bembelimen | |
| Labels |
Added:
?
|
||
Thanks
@wilsonge please review and we need a test