Feeling Lucky
NPM Resource Changed
PR-5.0-dev
Dark Mode
[#42073] - [5.0] code-color dark mode
- Fixed in Code Base
- 7 Oct 2023
- Medium
- Build: 5.0-dev
- # 42073
- Diff
- brianteeman:pink
User tests: Successful: Unsuccessful:
Overrides the $pink variable from bootstrap to improve contrast and ensure it meets accessibility contrast standards
Pull Request for Issue #42072 .
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
C-Lodder
- comment
- 6 Oct 2023
That said, #d7488b is still too dark for the #212529 background
brianteeman
- comment
- 6 Oct 2023
Please test again - not by testing the pink directly
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
|
||
brianteeman
- comment
- 6 Oct 2023
Changed from $pink to $color-code-dark
Quy
- comment
- 7 Oct 2023
I have tested this item ✅ successfully on a81ff8f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42073.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-07 13:22:57 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
Dark Mode
|
||
Doesn't work for me. Still ends up being the original colour.
This seems to work though: