Release Blocker NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar dgrammatiko
dgrammatiko
5 Oct 2023

Pull Request for Issue #42052 .

Summary of Changes

  • use SCSS
  • Move the css files for fields to their relative scss folder
  • use the rtlcss to reduce duplicate code

Testing Instructions

Check Bothe the calendar (ltr/rtl) and the media field (ie: intro image)

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed
  • No documentation changes for manual.joomla.org needed
avatar dgrammatiko dgrammatiko - open - 5 Oct 2023
avatar dgrammatiko dgrammatiko - change - 5 Oct 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 5 Oct 2023
Category Repository NPM Change
avatar dgrammatiko dgrammatiko - change - 5 Oct 2023
The description was changed
avatar dgrammatiko dgrammatiko - edited - 5 Oct 2023
avatar dgrammatiko dgrammatiko - change - 5 Oct 2023
Labels Added: NPM Resource Changed PR-5.0-dev
avatar dgrammatiko dgrammatiko - change - 5 Oct 2023
The description was changed
avatar dgrammatiko dgrammatiko - edited - 5 Oct 2023
avatar Quy
Quy - comment - 5 Oct 2023

Not readable.

42060-calendar

avatar dgrammatiko dgrammatiko - change - 5 Oct 2023
Labels Added: Release Blocker
avatar dgrammatiko
dgrammatiko - comment - 5 Oct 2023

@Quy should be ready for testing now

avatar HLeithner
HLeithner - comment - 5 Oct 2023

We are in rc can we have a simple pr? It does it need more the just the 2 svg files? Why has the CSS moved?

avatar dgrammatiko
dgrammatiko - comment - 5 Oct 2023

@HLeithner i got carried away. Will just add the svgs and patch the css var but probably tomorrow

avatar HLeithner
HLeithner - comment - 5 Oct 2023

Thx tomorrow is fine we will have a rc on Tuesday.

avatar dgrammatiko
dgrammatiko - comment - 5 Oct 2023

Should be ok now, only the patch

Screenshot 2023-10-06 at 01 09 53
Screenshot 2023-10-06 at 01 09 34
Screenshot 2023-10-06 at 01 09 25

avatar brianteeman brianteeman - test_item - 5 Oct 2023 - Tested unsuccessfully
avatar brianteeman brianteeman - test_item - 5 Oct 2023 - Not tested
avatar brianteeman brianteeman - test_item - 5 Oct 2023 - Tested successfully
avatar brianteeman
brianteeman - comment - 5 Oct 2023

I have tested this item ✅ successfully on 5368240


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42060.

avatar HLeithner
HLeithner - comment - 6 Oct 2023

can we get a test here please?

avatar Quy Quy - test_item - 6 Oct 2023 - Tested successfully
avatar Quy
Quy - comment - 6 Oct 2023

I have tested this item ✅ successfully on 4e74a71


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42060.

avatar HLeithner HLeithner - change - 7 Oct 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-10-07 09:35:28
Closed_By HLeithner
avatar HLeithner HLeithner - close - 7 Oct 2023
avatar HLeithner HLeithner - merge - 7 Oct 2023
avatar HLeithner
HLeithner - comment - 7 Oct 2023

Thanks

Add a Comment

Login with GitHub to post a comment