Feeling Lucky
Release Blocker
NPM Resource Changed
PR-5.0-dev
[#42060] - [5.0] Fix the calendar
- Fixed in Code Base
- 7 Oct 2023
- Medium
- Build: 5.0-dev
- # 42060
- Diff
- dgrammatiko:5.0-dev-cal
User tests: Successful: Unsuccessful:
Pull Request for Issue #42052 .
Summary of Changes
- use SCSS
- Move the css files for fields to their relative scss folder
- use the rtlcss to reduce duplicate code
Testing Instructions
Check Bothe the calendar (ltr/rtl) and the media field (ie: intro image)
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
- No documentation changes for docs.joomla.org needed
- No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
|
||
| Labels |
Added:
Release Blocker
|
||
HLeithner
- comment
- 5 Oct 2023
We are in rc can we have a simple pr? It does it need more the just the 2 svg files? Why has the CSS moved?
dgrammatiko
- comment
- 5 Oct 2023
@HLeithner i got carried away. Will just add the svgs and patch the css var but probably tomorrow
HLeithner
- comment
- 5 Oct 2023
Thx tomorrow is fine we will have a rc on Tuesday.
dgrammatiko
- comment
- 5 Oct 2023
Should be ok now, only the patch
brianteeman
- comment
- 5 Oct 2023
I have tested this item ✅ successfully on 5368240
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42060.
HLeithner
- comment
- 6 Oct 2023
can we get a test here please?
Quy
- comment
- 6 Oct 2023
I have tested this item ✅ successfully on 4e74a71
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42060.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-07 09:35:28 |
| Closed_By | ⇒ | HLeithner |
HLeithner
- comment
- 7 Oct 2023
Thanks
Not readable.