[#42054] - [5.0] Sample Data Titles contrast a11y
- Fixed in Code Base
- 5 Oct 2023
- Medium
- Build: 5.0-dev
- # 42054
- Diff
- brianteeman:sample_data_title_contrast_a11y
User tests: Successful: Unsuccessful:
Summary of Changes
In the changes to support dark mode the color was changed for the titles of the sample data (highlighted below) which unfortunately fails the contrast checks in both light and dark mode.
This PR addresses that.
It is NOT the same as it was in j4 to make the dark mode change automatic. Its really a minor thing but as its on the home page it would be highlighted immediately by anyone reviewing joomla for accessibility
@wilsonge you ok with this change. its neither the same as j4 nor your version of atum for j5
Testing Instructions
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
HLeithner
- | Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-05 14:37:45 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
Dark Mode
|
||
I have tested this item ✅ successfully on 8fdad72
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42054.