[#42042] - [5.0] Set organization as default to activate schemaorg by default
- Fixed in Code Base
- 4 Oct 2023
- Medium
- Build: 5.0-dev
- # 42042
- Diff
- bembelimen:schemaorg/improve-defaults
User tests: Successful: Unsuccessful:
Pull Request for Issue #42035 .
Summary of Changes
Set organization as default so by default the schema.org is active.
Testing Instructions
Migrate from 4.4 or do a fresh install. Have some articles installed (sample data or your own).
Go to blog view, archive, article.
Actual result BEFORE applying this Pull Request
No rich snippets for articles available.
Expected result AFTER applying this Pull Request
Rich snippets for articles available.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
I have tested this item ✅ successfully on c25cb15
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42042.
Please do also set the default value in the manifest file to organization.
| Labels |
Added:
PR-5.0-dev
|
||
I've restored @brianteeman 's test result in the issue tracker as the commit which has invalidated the test count was just the default value in the XML file.
Shouldnt we also set this in the database on install/upgrade
Shouldnt we also set this in the database on install/upgrade
Is not really necessary if we use the same default values everywhere in PHP. Would also not do any harm but possibly increase maintenance effort if the default changes with a later development.
we need a second test for this pr please
I have tested this item ✅ successfully on baf7180
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42042.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42042.
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-04 17:58:18 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
Release Blocker
bug
|
||
thx
Just worked it out at the same time. Slightly different solution but the same effect.
For reference my solution was to set the values for the params field in the plugin from blank to
{"baseType":"organization","user":"0","name":"","image":"","socialmedia":[]}which is exactly what happens when you save the plugin for the first time