[#42036] - [4.4] Proposed fix for Workflow transition error
- Fixed in Code Base
- 30 Oct 2023
- Medium
- Build: 4.4-dev
- # 42036
- Diff
- kochinc:4.4-dev
User tests: Successful: Unsuccessful:
Pull Request for Issue #42031.
Summary of Changes
Restructure codes in function getValidTransition() in file libraries/src/Workflow/Workflow.php so that it works with PostgreSQL.
Testing Instructions
It needs to use a PostgreSQL database to reproduce the problem.
- Enable Workflow.
- From left menu, select Content -> Articles.
- From the Stage column, click on one of the item to change transition.
Actual result BEFORE applying this Pull Request
An error has occurred.
42601 42601, 7, ERROR: syntax error at or near "WHERE" LINE 5: WHERE "t"."id" = $1 AND "t"."workflow_id" = "w"."id" AND "t"... ^
Expected result AFTER applying this Pull Request
No error returned and new transition is correctly set.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
| Status | New | ⇒ | Pending |
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Labels |
Added:
PR-4.4-dev
|
||
I have tested this item ✅ successfully on 73e5726
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42036.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42036.
| Labels |
Added:
?
bug
|
||
HLeithner
- | Title |
|
||||||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Labels |
Added:
?
Removed: ? |
||
| Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-10-30 21:27:11 |
| Closed_By | ⇒ | MacJoom | |
| Labels |
Added:
?
Removed: ? |
||
I have tested this item ✅ successfully on 73e5726
The PR fixes the issue for PostgreSQL, and on MySQL it works as well as before. I've tested both.
There are 2 deprecated warnings in PHP (using PHP 8.1.2), but they happen also without this PR in the same way. This PR just makes them appear on PostgreSQL, too, because the issue doesn't happen anymore so the transition takes place.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42036.