Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#42032] - workflow standard sql

PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
3 Oct 2023

Pull Request for Issue #42031 .

Summary of Changes

Testing Instructions

Actual result BEFORE applying this Pull Request

Expected result AFTER applying this Pull Request

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar alikon alikon - open - 3 Oct 2023
avatar alikon alikon - change - 3 Oct 2023
Status New ⇒ Pending
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2023
Category ⇒ Libraries
avatar richard67
richard67 - comment - 3 Oct 2023

The issue has been reported for 4.3.4, so a fix should be done for the 4.4-dev branch and then be merged up to 5.0-dev.

avatar kochinc
kochinc - comment - 3 Oct 2023

There was a mistake in the join() call. Please see the revised commit at #42031.

avatar richard67
richard67 - comment - 3 Oct 2023

There was a mistake in the join() call. Please see the revised commit at #42031.

@kochinc Could you make a pull request from that commit? Just referring to it in an issue doesn’t make it usable yet.

avatar kochinc
kochinc - comment - 3 Oct 2023

There was a mistake in the join() call. Please see the revised commit at #42031.

@kochinc Could you make a pull request from that commit? Just referring to it in an issue doesn’t make it usable yet.

Done. See PR #42036.

avatar richard67
richard67 - comment - 4 Oct 2023

@alikon I think @kochinc 's PR #42036 is better because it removes the condition also from the where clause (besides adding it to the join like both PRs do. In addition his PR is already for 4.4-dev. I suggest to close this one here in favour of PR #42036 .

avatar alikon alikon - close - 4 Oct 2023
avatar alikon alikon - change - 4 Oct 2023
Status Pending ⇒ Closed
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-10-04 09:59:35
Closed_By ⇒ alikon
Labels Added: PR-5.0-dev

Add a Comment

Login with GitHub to post a comment