Feature RTC Language Change PBF PR-5.1-dev PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
30 Sep 2023

Summary of Changes

This PR updates both the site and the admin feed modules.

The original intent was just to remove the inline styles but it became clear that neither of these modules were fit for purpose.

  • inline style replaced with html valid and accessible dir elements
  • noopener noreferrer
  • unused variables removed
  • adopted consistent coding of the if statements as used in all other tmpl (thanks @hackware)
  • kept the existing site module css classes (even though they dont exist in cassiopeia for b/c with 3pd templates)
  • improve xss protection on admin module links
  • add some basic styling on admin module
  • remove overly complex and superflous rtl/ltr code

Testing Instructions

Create 3 newsfeed modules for both site and admin as below

  1. set the direction to rtl and the url to https://www.aljazeera.net/aljazeerarss/a7c186be-1baa-4bd4-9d80-a84db769f779/73d0e1b4-532f-45ef-b135-bfdff8b8cab9

  2. Leave direction at the default ltr and the url to https://www.joomla.org/announcements.feed?type=rss

  3. set the url to an invalid rss feed eg https://www.joomla.org

Before PR

image

image

After PR

no visual changes in cassiopeia

image

Additional Comment

The Component also needs some similar reworking

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Votes

# of Users Experiencing Issue
0/1
Average Importance Score
5.00

9e4498a 30 Sep 2023 avatar brianteeman site
e0ed500 30 Sep 2023 avatar brianteeman admin
ca49e71 30 Sep 2023 avatar brianteeman debug
avatar joomla-cms-bot joomla-cms-bot - change - 30 Sep 2023
Category Modules Administration Front End
avatar brianteeman brianteeman - open - 30 Sep 2023
avatar brianteeman brianteeman - change - 30 Sep 2023
Status New Pending
avatar HLeithner HLeithner - change - 30 Sep 2023
Title
[5.0] Feed Modules
[5.1] Feed Modules
avatar HLeithner HLeithner - edited - 30 Sep 2023
avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar brianteeman brianteeman - change - 3 Oct 2023
Labels Added: Feature PR-5.1-dev
avatar joomla-cms-bot joomla-cms-bot - change - 3 Oct 2023
Category Modules Administration Front End Administration Language & Strings Modules Front End
avatar Quy Quy - change - 22 Feb 2024
Labels Added: Language Change PBF
avatar ufuk-avcu ufuk-avcu - test_item - 24 Feb 2024 - Tested successfully
avatar ufuk-avcu
ufuk-avcu - comment - 24 Feb 2024

I have tested this item ✅ successfully on da9a380


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42000.

avatar viocassel viocassel - test_item - 24 Feb 2024 - Tested successfully
avatar viocassel
viocassel - comment - 24 Feb 2024

I have tested this item ✅ successfully on da9a380


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42000.

avatar hl-dev-DE hl-dev-DE - test_item - 24 Feb 2024 - Tested successfully
avatar hl-dev-DE
hl-dev-DE - comment - 24 Feb 2024

I have tested this item ✅ successfully on da9a380


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42000.

avatar richard67 richard67 - change - 24 Feb 2024
Status Pending Ready to Commit
avatar richard67
richard67 - comment - 24 Feb 2024

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/42000.

avatar Razzo1987 Razzo1987 - change - 27 Feb 2024
Labels Added: RTC
avatar HLeithner
HLeithner - comment - 24 Apr 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
[5.1] Feed Modules
[5.2] Feed Modules
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar brianteeman brianteeman - change - 24 Apr 2024
Status Ready to Commit Closed
Closed_Date 0000-00-00 00:00:00 2024-04-24 19:07:27
Closed_By brianteeman
Labels Added: PR-5.2-dev
avatar brianteeman
brianteeman - comment - 24 Apr 2024

Closed due to lack of any interest - automatic rebases break things.

avatar brianteeman brianteeman - close - 24 Apr 2024

Add a Comment

Login with GitHub to post a comment