[#41993] - [5.0] Remove unused SCSS from cpanel file
- Fixed in Code Base
- 30 Sep 2023
- Medium
- Build: 5.0-dev
- # 41993
- Diff
- wilsonge:fix/remove-unused-cpanel-scss
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
This removes some as far as I can tell unused SCSS from the cpanel module. I cannot find any references to .cpanel-add-module-icon-help, .com-cpanel-help, .cpanel-add-module-icon-system or .com-cpanel-system inside core.
Additionally when viewing the help page in the main menu or any of the cpanel dashboards I can't see any visually differences changes after applying this
Testing Instructions
Validate classes don't exist in core and all cpanel views (primary dashboard, system dashboard and help page) are unchanged after applying this PR
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Status | New | ⇒ | Pending |
I have tested this item ✅ successfully on 0f28b1b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41993.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
|
||
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41993.
HLeithner
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-30 20:06:13 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
I have tested this item ✅ successfully on 0f28b1b
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41993.