User tests: Successful: Unsuccessful:
.
Status | Pending | ⇒ | New |
Labels |
Added:
?
|
Title |
|
Hi @infograf768,
I thought it was enough clear what code was missing, by the way....
scenario:
The only message returned is "Installation unexpectedly terminated:" (check line 397 of ROOT\libraries\cms\installer\installer.php). Why? because the function abort($msg = null, $type = null) is called with an empty error message due to the missing code (check the lines I've modified).
I know the JText should be used, and it also need to be used on line 397 of ROOT\libraries\cms\installer\installer.php, My commit was a quick fix, this is the first time I contribute to the JOOMLA development so I didn't wanna do too many modifications on code.
I'll add the full patch with the language string later......after dinner :-)
Status | New | ⇒ | Pending |
Category | ⇒ | Installation Libraries Updating |
Please update your PR to latest staging and fix the merge conflicts.
what "PR" stands for?
Pullrequest. This thing that you are looking at right now.
I have tested this item unsuccessfully on f7db062
Patch could not e loaded
Error
The patch could not be applied because the repository is missing
As we can't merge this PR (deleted repo) and the current installer code throws exections instend use abort i'm going to close here. Thanks.
Status | Pending | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2015-10-25 12:27:07 |
Closed_By | ⇒ | zero-24 |
Labels |
Added:
?
|
Please be kind enough to explain what is missing, what you expect to get and how this should be tested.
Also, you are using hard text in this patch which is untranslatable. Change to JText