? ? Pending

User tests: Successful: Unsuccessful:

avatar bygiro
bygiro
31 Aug 2014

.

avatar bygiro bygiro - open - 31 Aug 2014
avatar jissues-bot jissues-bot - change - 31 Aug 2014
Status Pending New
Labels Added: ?
avatar bygiro bygiro - change - 31 Aug 2014
Title
Missing enough INFO on FAILED installation
Missing enough INFO on FAILED component installation
avatar infograf768
infograf768 - comment - 31 Aug 2014

Please be kind enough to explain what is missing, what you expect to get and how this should be tested.
Also, you are using hard text in this patch which is untranslatable. Change to JText

avatar bygiro
bygiro - comment - 31 Aug 2014

Hi @infograf768,
I thought it was enough clear what code was missing, by the way....
scenario:

  • extension installation process using the "Upload & Install Joomla Extension"
  • installation is failed due to something unexpected in the extension installer but not explained by the Jinstaller.

The only message returned is "Installation unexpectedly terminated:" (check line 397 of ROOT\libraries\cms\installer\installer.php). Why? because the function abort($msg = null, $type = null) is called with an empty error message due to the missing code (check the lines I've modified).
I know the JText should be used, and it also need to be used on line 397 of ROOT\libraries\cms\installer\installer.php, My commit was a quick fix, this is the first time I contribute to the JOOMLA development so I didn't wanna do too many modifications on code.
I'll add the full patch with the language string later......after dinner :-)

avatar infograf768
infograf768 - comment - 1 Sep 2014

@bygiro
When modifying administrator en-GB.lib.joomla.ini, please also update the site/language/en-GB/en-GB.lib.joomla.ini.

avatar brianteeman brianteeman - change - 1 Sep 2014
The description was changed
Status New Pending
avatar brianteeman brianteeman - change - 17 Oct 2014
Category Installation Libraries Updating
avatar Hackwar
Hackwar - comment - 3 Feb 2015

Please update your PR to latest staging and fix the merge conflicts.

avatar bygiro
bygiro - comment - 3 Feb 2015

what "PR" stands for?

avatar Hackwar
Hackwar - comment - 3 Feb 2015

Pullrequest. This thing that you are looking at right now. :wink:

avatar roland-d
roland-d - comment - 22 Oct 2015

@bygiro Can you redo this pull request or shall I find someone else to do it? Thanks.

avatar KingLouis1 KingLouis1 - test_item - 24 Oct 2015 - Tested unsuccessfully
avatar KingLouis1
KingLouis1 - comment - 24 Oct 2015

I have tested this item :red_circle: unsuccessfully on f7db062

Patch could not e loaded

Error

The patch could not be applied because the repository is missing


This comment was created with the J!Tracker Application at issues.joomla.org/joomla-cms/4199.

avatar zero-24
zero-24 - comment - 25 Oct 2015

As we can't merge this PR (deleted repo) and the current installer code throws exections instend use abort i'm going to close here. Thanks.

avatar zero-24 zero-24 - change - 25 Oct 2015
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2015-10-25 12:27:07
Closed_By zero-24
avatar zero-24 zero-24 - close - 25 Oct 2015
avatar joomla-cms-bot joomla-cms-bot - change - 25 Oct 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment