Feature ? PR-5.1-dev Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
28 Sep 2023

Summary of Changes

Remove redundant ELSE usage.

Testing Instructions

Apply patch.

Actual result BEFORE applying this Pull Request

Complex code.

Expected result AFTER applying this Pull Request

Simple code.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

142bf1c 28 Sep 2023 avatar Denitz fix
avatar joomla-cms-bot joomla-cms-bot - change - 28 Sep 2023
Category Unit Tests Repository Administration com_admin SQL
avatar Denitz Denitz - open - 28 Sep 2023
avatar Denitz Denitz - change - 28 Sep 2023
Status New Pending
avatar brianteeman
brianteeman - comment - 28 Sep 2023

Wrong branch

avatar Quy Quy - test_item - 28 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 28 Sep 2023

I have tested this item ✅ successfully on da378aa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41983.

avatar alikon alikon - test_item - 28 Sep 2023 - Tested successfully
avatar alikon
alikon - comment - 28 Sep 2023

I have tested this item ✅ successfully on da378aa


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41983.

avatar alikon alikon - change - 28 Sep 2023
Status Pending Ready to Commit
avatar alikon
alikon - comment - 28 Sep 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41983.

avatar HLeithner HLeithner - change - 30 Sep 2023
Title
[5.0] Redundant else usage
[5.1] Redundant else usage
avatar HLeithner HLeithner - edited - 30 Sep 2023
avatar joomla-cms-bot joomla-cms-bot - change - 30 Sep 2023
Category Unit Tests Repository Administration com_admin SQL Administration com_templates Libraries
avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar Denitz Denitz - change - 3 Oct 2023
Labels Added: Feature ? PR-5.0-dev
avatar Quy Quy - change - 6 Oct 2023
Labels Added: PR-5.1-dev
Removed: PR-5.0-dev
avatar Quy
Quy - comment - 6 Oct 2023

@Denitz Please fix phpcs.

e8855da 6 Oct 2023 avatar Denitz cs
avatar Denitz
Denitz - comment - 6 Oct 2023

@Quy Done.

avatar Razzo1987 Razzo1987 - change - 1 Nov 2023
Labels Added: ?
Removed: ?
avatar Quy Quy - change - 2 Nov 2023
Labels Added: ?
Removed: ?
avatar HLeithner HLeithner - change - 2 Nov 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-11-02 14:20:39
Closed_By HLeithner
Labels Added: ?
Removed: ?
avatar HLeithner HLeithner - close - 2 Nov 2023
avatar HLeithner HLeithner - merge - 2 Nov 2023
avatar HLeithner
HLeithner - comment - 2 Nov 2023

thanks

Add a Comment

Login with GitHub to post a comment