Feeling Lucky
Feature
Maintainers Checked
PR-5.1-dev
[#41981] - [5.1] Duplicate DispatcherAwareInterface implementation
- Fixed in Code Base
- 2 Mar 2024
- Medium
- Build: 5.0-dev
- # 41981
- Diff
- Denitz:5.0_Duplicate_DispatcherAwareInterface_implementation
User tests: Successful: Unsuccessful:
Summary of Changes
BaseApplication, CliApplication and ConsoleApplication should not implement DispatcherAwareInterface and use DispatcherAwareTrait because they extend AbstractApplication which already implements and uses this interface and trait.
Testing Instructions
Apply patch.
Actual result BEFORE applying this Pull Request
Duplicate interface inheritance and trait usage.
Expected result AFTER applying this Pull Request
Simpler code.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
rdeutz
- comment
- 11 Jan 2024
LGTM, code review
| Labels |
Added:
Feature
Maintainers Checked
PR-5.1-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-03-02 22:54:34 |
| Closed_By | ⇒ | bembelimen |
bembelimen
- comment
- 2 Mar 2024
Thx
This pull request has been automatically rebased to 5.1-dev.