[#41974] - [5.2] Remove unused ArchiveModel::getData()
- Closed
- 20 Jul 2024
- Medium
- Build: 5.0-dev
- # 41974
- Diff
- Denitz:_5.0]_Remove_unused_ArchiveModel__getData()
User tests: Successful: Unsuccessful:
Summary of Changes
ArchiveModel::getData() is unused, even calls the missed _buildQuery()
Testing Instructions
Apply patch.
Actual result BEFORE applying this Pull Request
Invalid unused method.
Expected result AFTER applying this Pull Request
No invalid unused method.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Front End com_content |
| Status | New | ⇒ | Pending |
I mean normally yes. But given the method is clearly going to give a fatal error if it's called. Because of that in this very specific case it's probably safe to remove in 5.0 and we can just shove a deprecation notice in 4.4 even at this stage.
| Title |
|
||||||
This pull request has been automatically rebased to 5.1-dev.
This pull request has been automatically rebased to 5.2-dev.
| Title |
|
||||||
You are right that this method needs to be removed, but since we need to deprecate it, we have to wait until 7.0 now. I stumbled upon this as well and created #43354, not knowing about your PR. Since my PR does the deprecation, fixes the method for now and then allows to remove it in 7.0, I would close this one and ask you to test #43354 to get this finally moving. Thank you for your work!
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-20 22:13:32 |
| Closed_By | ⇒ | Hackwar | |
| Labels |
Added:
Feature
Maintainers Checked
b/c break
PR-5.1-dev
PR-5.2-dev
|
||
surely this needs to be deprecated before it can be removed