Feature Maintainers Checked PR-5.2-dev Pending

User tests: Successful: Unsuccessful:

avatar Denitz
Denitz
28 Sep 2023

Summary of Changes

Method declarations differ from parent declaration, useless pass-by-ref, invalid pass-by-ref, useless argument in str_replace()

Testing Instructions

Apply patch.

Actual result BEFORE applying this Pull Request

IDE errors, invalid usage of pass-by-ref

Expected result AFTER applying this Pull Request

No IDE errors.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

7022e2a 28 Sep 2023 avatar Denitz fix
avatar joomla-cms-bot joomla-cms-bot - change - 28 Sep 2023
Category Administration com_menus com_messages com_modules com_templates
avatar Denitz Denitz - open - 28 Sep 2023
avatar Denitz Denitz - change - 28 Sep 2023
Status New Pending
avatar HLeithner HLeithner - change - 30 Sep 2023
Title
[5.0] Invalid pass-by-reference usage
[5.1] Invalid pass-by-reference usage
avatar HLeithner HLeithner - edited - 30 Sep 2023
avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 5.1-dev.

avatar Quy Quy - change - 21 Feb 2024
Labels Added: Feature Maintainers Checked PR-5.1-dev
avatar HLeithner
HLeithner - comment - 24 Apr 2024

This pull request has been automatically rebased to 5.2-dev.

avatar HLeithner HLeithner - change - 24 Apr 2024
Title
[5.1] Invalid pass-by-reference usage
[5.2] Invalid pass-by-reference usage
avatar HLeithner HLeithner - edited - 24 Apr 2024
avatar Hackwar Hackwar - change - 28 Aug 2024
Labels Added: PR-5.2-dev
Removed: PR-5.1-dev
avatar Hackwar
Hackwar - comment - 28 Aug 2024

I'm merging this based on code review by @rdeutz and me. Thank you @Denitz for your contribution!

avatar Hackwar Hackwar - change - 28 Aug 2024
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2024-08-28 12:56:43
Closed_By Hackwar
avatar Hackwar Hackwar - close - 28 Aug 2024
avatar Hackwar Hackwar - merge - 28 Aug 2024

Add a Comment

Login with GitHub to post a comment