Feeling Lucky
?
NPM Resource Changed
PR-5.0-dev
[#41955] - [5.0] Remove unused SCSS
- Fixed in Code Base
- 30 Sep 2023
- Medium
- Build: 5.0-dev
- # 41955
- Diff
- wilsonge:fix/login-remove-unused-scss
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Removes some as far as I can tell unused SCSS from the login scss. The motivation is that I'm trying to reduce the amount of places we're using var(--template-special-color);
Testing Instructions
Check the login page (including ideally with some passkey & mfa methods enabled. Ideally there should be no differences.
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Status | New | ⇒ | Pending |
brianteeman
- comment
- 28 Sep 2023
lgtm
brianteeman
- comment
- 28 Sep 2023
I have tested this item ✅ successfully on 282800f
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41955.
| Status | Pending | ⇒ | Ready to Commit |
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
|
||
Quy
- comment
- 28 Sep 2023
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41955.
HLeithner
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-30 20:23:50 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
?
|
||
I have tested this item ✅ successfully on 282800f
I tested with Passkey and Code by email - no obvious differences and it worked fine.
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41955.