Summary of Changes

This pull request (PR) improves the error messages from the check for the uploaded package file which was added with PR #41757 to the Joomla Update component.

1. The name of the selected update package is added to all messages. This is extremely helpful if the user has just picked the wrong file by mistake.
2. To all messages, a 2nd line is added which provides information on the right package and a link to the official Joomla download page.
3. The message on an attempt to downgrade is extended by the version numbers (package and installed).
4. The wording used in these language strings has been harmonized.

The link to the official Joomla download page points to https://downloads.joomla.org/latest , which might not be suitable for every use case, e.g. nightly builds or development versions.

But we use this link already elswhere for the same purpose, providing an entry point where people can start to look for the right package and which is suitable in most cases.

As we currently do not build the small patch packages, there are only the "Upgrade" packages available.

Later when we can build the smaller patch packages again and they will be available at the downloads pages, we might have to change the "Upgrade Package" to "Upgrade or Update Package" in the language strings touched by this PR.

Testing Instructions

Test 1: Upload a file which is not a ZIP file

In the Joomla Update Component, go to "Upload & Update" and then use the button to chose a file.

In the file selection dialogue, change the file type filter from ".zip" to "All files (.*)".

Select any file which is not a ZIP file, e.g. an image, a CSS file, whatever comes into your mind, and use the "Open" button to upload the file.

Test 2: Upload a full installation package

In the Joomla Update Component, go to "Upload & Update" and then chose a full installation package.

Test 3: Upload an update ZIP package for a Joomla version lower than the current Joomla version, i.e. try to downgrade

In the Joomla Update Component, go to "Upload & Update" and then chose an update ZIP package for a Joomla version lower than the current Joomla version.

Test 4: Upload a "hacked" update ZIP package which doesn't contain the "administrator/manifests/files/joomla.xml" file

Modify an update ZIP package with which updating should work by removing the "administrator/manifests/files/joomla.xml" file from the ZIP file, e.g. by unpacking the package, removing the XML file and packing the package again.

In the Joomla Update Component, go to "Upload & Update" and then chose the previously modified update ZIP package.

Test 5: Upload a "hacked" update ZIP package in which the "administrator/manifests/files/joomla.xml" file is missing the version

Modify an update ZIP package with which updating should work by removing the <version> element from the "administrator/manifests/files/joomla.xml" file, e.g. by unpacking the package, editing the XML file and packing the package again.

In the Joomla Update Component, go to "Upload & Update" and then chose the previously modified update ZIP package.

Actual result BEFORE applying this Pull Request

Alert with error message without telling the name of the selected file and without a link to the official Joomla download page.

Expected result AFTER applying this Pull Request

Alert with error message telling the name of the selected file and having a 2nd line which provides a link to the official Joomla download page and information on what to look for.

Test 3 (downgrade): The error message shows the version from the package file and the installed version used for the check.

Link to documentations

Please select:

• No documentation changes for docs.joomla.org needed

• No documentation changes for manual.joomla.org needed