? Failure

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
29 Aug 2014

The create an account form has a label to explain that a * by a field is a required field
This is missing on the edit profile field - this PR adds it

avatar brianteeman brianteeman - open - 29 Aug 2014
avatar jissues-bot jissues-bot - change - 29 Aug 2014
Status Pending New
Labels Added: ?
avatar n9iels
n9iels - comment - 29 Aug 2014

@test: works fine for me, a good addition.

The space between the required label and the title is bigger in the edit form than the registration form. This is because there is a control-group div with a hidden field above required label at the edit form. Maybe whe can hide this div by adding hidden to the class?

avatar Bakual
Bakual - comment - 29 Aug 2014

We don't show that text in all other forms from what I see. The only one where it is used is the user registration.

Also the language string used indicates that it's only used in the registration process, not in the profile which uses a different prefix. So to be consistent, you would have to add a new language string I think.

If a template overrides the label JLayout to not include that asterisk (as discussed in the other PR #4139), then you would have a misleading text. It would be quite hard to actually remove that line in a template override because it comes from the form and not the layout itself. In the end you would make overrides harded with this change.

Also given that the asterisk is actually quite common and standard in many forms, I doubt you really need to explain it to the users nowadays. I would actually rather remove it from the registration form, but that's me :smiley:

avatar beat
beat - comment - 29 Aug 2014

Not very user-friendly to add intrusive obvious instructions in important forms. If you want to add text for the image-blinds, just add a title attribute to the span surrounding the star, so people see on hover or tap what it means. And maybe add html5 semantic to the input.

Stars are part of standard UX nowadays. Worldwide. Imho.

avatar nternetinspired
nternetinspired - comment - 29 Aug 2014

We don't show that text in all other forms from what I see. The only one where it is used is the user registration.

:100:

The account creation form is the only form that currently includes this, IMO redundant, legend. I'd rather see it removed from this form than added to any others.

avatar brianteeman brianteeman - change - 29 Aug 2014
Status New Pending
avatar brianteeman brianteeman - close - 17 Oct 2014
avatar brianteeman brianteeman - change - 17 Oct 2014
Status Pending Closed
avatar brianteeman brianteeman - close - 17 Oct 2014
avatar brianteeman brianteeman - change - 17 Oct 2014
Closed_Date 0000-00-00 00:00:00 2014-10-17 22:29:23
avatar brianteeman brianteeman - head_ref_deleted - 20 Dec 2014

Add a Comment

Login with GitHub to post a comment