User tests: Successful: Unsuccessful:
The indexer parses strings through different string parsers (like Joomla\Component\Finder\Administrator\Indexer\Parser\Html
).
The main parse
method (Joomla\Component\Finder\Administrator\Indexer\Parser::parse()
) attempts to chop long strings in chunks, and then passes each chunk to the process
method.
It will truncate chunks to the last space found in the string.
But it doesn't include this space in the string. This will cause the spaces to get lost in the string concatenation for the final $return
string.
This PR fixes the issue.
To test, create an article with this content:
<p>aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX</p>
and make sure it's indexed by Smart Search.
Before the PR is applied, using Smart Search you can search for aaaXXX
(so no space) and get a result.
After the PR is applied (and re-saving the article), you won't find any more results for aaaXXX
(with no space), but will have results when searching for aaa XXX
.
Category | ⇒ | Administration com_finder |
Status | New | ⇒ | Pending |
This pull request has been automatically rebased to 4.4-dev.
Labels |
Added:
bug
PR-4.4-dev
|
I have tested this item ✅ successfully on 5a5c50d
Status | Pending | ⇒ | Ready to Commit |
RTC
Labels |
Added:
?
|
Sorry, I'll first fix the appveyor issue and will then merge this.
Labels |
Added:
?
Removed: ? |
Labels |
Added:
?
Removed: ? |
Status | Ready to Commit | ⇒ | Fixed in Code Base |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-11-03 13:02:24 |
Closed_By | ⇒ | Hackwar | |
Labels |
Added:
?
Removed: ? |
I have tested this item ✅ successfully on 3f4d3e6
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41937.