? bug PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar AndySDH
AndySDH
26 Sep 2023

Summary of Changes

The indexer parses strings through different string parsers (like Joomla\Component\Finder\Administrator\Indexer\Parser\Html).
The main parse method (Joomla\Component\Finder\Administrator\Indexer\Parser::parse()) attempts to chop long strings in chunks, and then passes each chunk to the process method.
It will truncate chunks to the last space found in the string.

But it doesn't include this space in the string. This will cause the spaces to get lost in the string concatenation for the final $return string.

This PR fixes the issue.

Testing Instructions

To test, create an article with this content:

<p>aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX aaa XXX</p>

and make sure it's indexed by Smart Search.

Actual result BEFORE applying this Pull Request

Before the PR is applied, using Smart Search you can search for aaaXXX (so no space) and get a result.

Expected result AFTER applying this Pull Request

After the PR is applied (and re-saving the article), you won't find any more results for aaaXXX (with no space), but will have results when searching for aaa XXX.

avatar joomla-cms-bot joomla-cms-bot - change - 26 Sep 2023
Category Administration com_finder
avatar AndySDH AndySDH - open - 26 Sep 2023
avatar AndySDH AndySDH - change - 26 Sep 2023
Status New Pending
avatar AndySDH AndySDH - change - 26 Sep 2023
The description was changed
avatar AndySDH AndySDH - edited - 26 Sep 2023
avatar AndySDH AndySDH - change - 26 Sep 2023
The description was changed
avatar AndySDH AndySDH - edited - 26 Sep 2023
avatar AndySDH AndySDH - change - 26 Sep 2023
The description was changed
avatar AndySDH AndySDH - edited - 26 Sep 2023
avatar AndySDH AndySDH - change - 26 Sep 2023
The description was changed
avatar AndySDH AndySDH - edited - 26 Sep 2023
avatar ceford ceford - test_item - 27 Sep 2023 - Tested successfully
avatar ceford
ceford - comment - 27 Sep 2023

I have tested this item ✅ successfully on 3f4d3e6


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41937.

avatar HLeithner
HLeithner - comment - 30 Sep 2023

This pull request has been automatically rebased to 4.4-dev.

avatar Hackwar Hackwar - change - 25 Oct 2023
Labels Added: bug PR-4.4-dev
avatar chmst chmst - test_item - 25 Oct 2023 - Tested successfully
avatar chmst
chmst - comment - 25 Oct 2023

I have tested this item ✅ successfully on 5a5c50d


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41937.

avatar Quy Quy - alter_testresult - 25 Oct 2023 - ceford: Tested successfully
avatar Quy Quy - change - 25 Oct 2023
Status Pending Ready to Commit
avatar Quy
Quy - comment - 25 Oct 2023

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41937.

avatar laoneo laoneo - change - 31 Oct 2023
Labels Added: ?
avatar Hackwar
Hackwar - comment - 2 Nov 2023

Sorry, I'll first fix the appveyor issue and will then merge this.

avatar Hackwar Hackwar - change - 2 Nov 2023
Labels Added: ?
Removed: ?
avatar Hackwar Hackwar - change - 3 Nov 2023
Labels Added: ?
Removed: ?
avatar Hackwar Hackwar - change - 3 Nov 2023
Status Ready to Commit Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-11-03 13:02:24
Closed_By Hackwar
Labels Added: ?
Removed: ?
avatar Hackwar Hackwar - close - 3 Nov 2023
avatar Hackwar Hackwar - merge - 3 Nov 2023

Add a Comment

Login with GitHub to post a comment