Language Change PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
25 Sep 2023

Fixes the accessibility of the links when in dark mode.

Summary of Changes

Adds a parameter to control the link color when in dark mode (this is a different color from the current one which doesn't meet a11y requirements).

I'll happily take any advice on how best to word both the label for the field and maybe even adding an option so it's clear. With us already talking "dark hue" and "dark text" it's really not that clear to the user what is going on (in my opinion)

Testing Instructions

Template link now accessible in dark mode to AA and controllable by the user in the template styles.

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 25 Sep 2023
Category Administration Language & Strings Templates (admin)
avatar wilsonge wilsonge - open - 25 Sep 2023
avatar wilsonge wilsonge - change - 25 Sep 2023
Status New Pending
avatar wilsonge wilsonge - change - 25 Sep 2023
The description was changed
avatar wilsonge wilsonge - edited - 25 Sep 2023
avatar wilsonge wilsonge - change - 25 Sep 2023
The description was changed
avatar wilsonge wilsonge - edited - 25 Sep 2023
avatar wilsonge wilsonge - change - 25 Sep 2023
The description was changed
avatar wilsonge wilsonge - edited - 25 Sep 2023
avatar wilsonge wilsonge - change - 25 Sep 2023
The description was changed
avatar wilsonge wilsonge - edited - 25 Sep 2023
avatar brianteeman
brianteeman - comment - 26 Sep 2023

lgtm

avatar wilsonge wilsonge - change - 26 Sep 2023
Title
[5.0Add parameter for setting template link color in dark mode
[5.0] Add parameter for setting template link color in dark mode
avatar wilsonge wilsonge - edited - 26 Sep 2023
avatar wilsonge
wilsonge - comment - 26 Sep 2023

OK I'll open it up then. Somehow I'm not sure this will be intuitive like I said. But better to at least allow a11y compliance

avatar Quy Quy - change - 26 Sep 2023
Labels Added: Language Change PR-5.0-dev
avatar HLeithner HLeithner - close - 30 Sep 2023
avatar HLeithner HLeithner - merge - 30 Sep 2023
avatar HLeithner HLeithner - change - 30 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-30 20:47:20
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 30 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment