Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41904] - Remove box shadow in toolbar

NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
23 Sep 2023

Summary of Changes

Fixes the double border showing in media manager toolbar when in dark mode. Note the box shadow removed is basically white which means it's totally invisible (and therefore also useless) in light mode.

Testing Instructions

Check the toolbar in the media manager view. Light mode no changes. In dark mode the box shadow is removed which is especially noticeable on the checkbox.

Actual result BEFORE applying this Pull Request

image

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 23 Sep 2023
Category ⇒ Repository NPM Change
avatar wilsonge wilsonge - open - 23 Sep 2023
avatar wilsonge wilsonge - change - 23 Sep 2023
Status New ⇒ Pending
avatar Quy Quy - test_item - 24 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 24 Sep 2023

I have tested this item ✅ successfully on 0819ac8

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41904.

avatar HLeithner HLeithner - change - 24 Sep 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-09-24 08:21:24
Closed_By ⇒ HLeithner
Labels Added: NPM Resource Changed PR-5.0-dev
avatar HLeithner HLeithner - close - 24 Sep 2023
avatar HLeithner HLeithner - merge - 24 Sep 2023
avatar HLeithner
HLeithner - comment - 24 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment