NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
23 Sep 2023

Pin boostrap to 5.3.2 and cypress-joomla to 0.0.16 for now.

avatar joomla-cms-bot joomla-cms-bot - change - 23 Sep 2023
Category NPM Change
avatar HLeithner HLeithner - open - 23 Sep 2023
avatar HLeithner HLeithner - change - 23 Sep 2023
Status New Pending
avatar HLeithner HLeithner - change - 23 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-23 19:03:51
Closed_By HLeithner
Labels Added: NPM Resource Changed PR-5.0-dev
avatar HLeithner HLeithner - close - 23 Sep 2023
avatar HLeithner HLeithner - merge - 23 Sep 2023
avatar laoneo
laoneo - comment - 26 Sep 2023

Why?

avatar HLeithner
HLeithner - comment - 26 Sep 2023

Why? Why? The uomerge of bootstrap failed and I broke cypress-joomla 0.0.18

avatar laoneo
laoneo - comment - 26 Sep 2023

Why did the upmerge of bootstrap fail? If you pin it to the version we have also in 4.4 it looks like all is ok and no pin is needed. There must be a valid reason to pin to a fixed patch version and I do not see one for bootstrap.

avatar HLeithner
HLeithner - comment - 26 Sep 2023

Don't know why the upmerge wasn't successful, should used ^3.5.2 for upgrade, will change this later.

Add a Comment

Login with GitHub to post a comment