PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar brianteeman
brianteeman
23 Sep 2023

When preg_replace is used, the first argument should be a regular expression. If it’s not a regex then str_replace does exactly the same thing as preg_replace without the performance drawback of the regex.

code review

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 23 Sep 2023
Category Administration com_admin
avatar brianteeman brianteeman - open - 23 Sep 2023
avatar brianteeman brianteeman - change - 23 Sep 2023
Status New Pending
avatar HLeithner HLeithner - change - 23 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-23 09:35:10
Closed_By HLeithner
Labels Added: PR-5.0-dev
avatar HLeithner HLeithner - close - 23 Sep 2023
avatar HLeithner HLeithner - merge - 23 Sep 2023

Add a Comment

Login with GitHub to post a comment