[#41880] - [5.0] 500 error when 404 and debug on [BLOCKER]
- Closed
- 23 Sep 2023
- Medium
- Build: 5.0-dev
- # 41880
- Diff
- brianteeman:18_issue_500_when_404_and_debug_on
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Enable debug and then trigger a 404 on the frontend
Instead of the regular 404 page we get a 404 and a 500
This is caused by the line commented out in this PR.
That line was added by #35655
Sorry I can't contribute a real solution as I don't understand the code. I was just able to locate the source and provide this PR to showcase the problem
joomla-cms-bot
- | Category | ⇒ | Front End Plugins |
| Status | New | ⇒ | Pending |
@brianteeman Please remove these 2 lines, and we will call it a fix, and please make it to 4.4-dev (it comes from there)
the plugin should not manipulate the session.
joomla-cms/plugins/system/debug/src/Extension/Debug.php
Lines 308 to 309 in d5ead74
@brianteeman I will take a look in 1h, we close the session in debug plugin in order to collect the queries related to session close.
@brianteeman @Fedik If we don't close the session, we won't see the queries from the session handler.
I've create PR for 4.4-dev, please check #41893
| Status | Pending | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-23 14:38:02 |
| Closed_By | ⇒ | brianteeman | |
| Labels |
Added:
bug
PR-5.0-dev
|
||
So I understand right that this PR is not a fix but just for demonstrating the issue? If yes: Maybe it would have been safer to use an issue and describe the code change for the test in that issue?