Summary of Changes

It is possible to assign SVG files to banners, however, the module does not reflect it, only allowing image files.

Notes:

An isImage function was created specifically for Banners. However, it should not be necessary to have such a function since the MediaHelper offers it as well. To ensure Banners support the same image file extensions as the rest of the core, I opted for the use of the MediaHelper instead.

SVG files act a bit differently than image files.
When forcing a width and a height on a image, the image will 'follow' those dimensions.
A SVG file will be scaled to fit its defined viewport. So it won't 'obey' a specific height if you set one for the banner.
Depending on your situation, you may have to restrict the SVG's height with max-height.

Use of SVGs in mod_banners is safe, the SVG files are checked in MediaHelper::getMimeType.

Testing Instructions

Create banners in the administration console. Some use standard image files, some use SVG files.

Actual result BEFORE applying this Pull Request

Only banners with standard image files are shown.

Expected result AFTER applying this Pull Request

Banners with standard image files and SVG files are shown.

Link to documentations

Please select:

• Documentation link for docs.joomla.org:

• No documentation changes for docs.joomla.org needed

• Pull Request link for manual.joomla.org: link (about the deprecation)

• No documentation changes for manual.joomla.org needed