PR-4.4-dev Pending

User tests: Successful: Unsuccessful:

avatar alikon
alikon
20 Sep 2023

Pull Request for Issue #41826

Summary of Changes

alter menutype field from 24 to 48

Testing Instructions

#41826

avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2023
Category SQL Administration com_admin Postgresql Installation
avatar alikon alikon - open - 20 Sep 2023
avatar alikon alikon - change - 20 Sep 2023
Status New Pending
avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2023
Category SQL Administration com_admin Postgresql Installation SQL Administration com_admin Postgresql Installation Front End Plugins
avatar alikon alikon - change - 20 Sep 2023
Labels Added: PR-4.4-dev
avatar chmst
chmst - comment - 20 Sep 2023

https://github.com/joomla/joomla-cms/blob/4.3-dev/administrator/components/com_menus/forms/menu.xml#L20
There is a maxlength for the input field which should be increased.

But I am not convinced, Every limitaion is a limitation and an automatically generated unique menuname could be a better solution.

Suppose for example hungarian and write a menu title like this in english.
en: Disability equality laws

Hungarian translation i > 48
hu: A fogyatékossággal élők egyenlőségére vonatkozó jogszabályok

avatar HLeithner
HLeithner - comment - 20 Sep 2023

I see no reason for increasing this field, it's only used as identifier and not as description

avatar richard67
richard67 - comment - 20 Sep 2023

Maybe blog sample data installation should be fixed so that it makes sure that the menutype values are unique, like we do it elsewhere for aliases when saving copies. This would for sure solve the (absolutely valid) scenario described in the issue, while increasing the length will only make it less likely happen.

avatar richard67
richard67 - comment - 21 Sep 2023

I think we only have to modify the blog sample data installation so that it uses only a substring of the translated language string which is short enough so that the language code always can be appended without exceeding the limit of 24, then we can be sure we don’t have the same value for 2 languages.

avatar alikon alikon - change - 21 Sep 2023
Status Pending Closed
Closed_Date 0000-00-00 00:00:00 2023-09-21 06:22:50
Closed_By alikon
avatar alikon alikon - close - 21 Sep 2023

Add a Comment

Login with GitHub to post a comment