[#41828] - [5.0] Check for string options for very old legacy XTD Buttons
- Fixed in Code Base
- 20 Sep 2023
- Medium
- Build: 5.0-dev
- # 41828
- Diff
- Fedik:fix-buttons-string-opts
User tests: Successful: Unsuccessful:
Issue for report #41827
Summary of Changes
In older Joomla the XTD button options was a "JS like object" string.
However this is not working for long time. The options should be as an array.
Testing Instructions
Add $button->options = "{handler: 'iframe', size: {x: 800, y: 500}}"; somewhere here
joomla-cms/plugins/editors-xtd/menu/src/Extension/Menu.php
Lines 60 to 62 in ef33d44
And open any article to edit.
Actual result BEFORE applying this Pull Request
An error
Expected result AFTER applying this Pull Request
No error
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
References:
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
tested and validate thanks
thanks for the feedback, for the future (I hope you test more prs now) please mark your tests a success in the issue tracker https://issues.joomla.org/tracker/joomla-cms/41828
I have tested this item ✅ successfully on fb46115
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41828.
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-20 09:20:48 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
bug
PR-5.0-dev
|
||
thanks
tested and validate
thanks