PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar HLeithner
HLeithner
20 Sep 2023

Pull Request for Issue #41821 .

Summary of Changes

Fallback to core naming schema for 3rd party extensions which uses JHtml as prefix for HTMLHelper classes.

Testing Instructions

Use an extensions which uses JHtmlXXX HTMLHelper

Actual result BEFORE applying this Pull Request

Doesn't work because we check only for the namespace version Joomla\CMS\HTML\HTMLHelper

Expected result AFTER applying this Pull Request

Work because we now check also for the legacy prefix version JHtml

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

Votes

# of Users Experiencing Issue
1/1
Average Importance Score
3.00

avatar joomla-cms-bot joomla-cms-bot - change - 20 Sep 2023
Category Libraries
avatar HLeithner HLeithner - open - 20 Sep 2023
avatar HLeithner HLeithner - change - 20 Sep 2023
Status New Pending
avatar micker
micker - comment - 20 Sep 2023

tested and valided


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41825.

avatar micker micker - test_item - 20 Sep 2023 - Tested successfully
avatar micker
micker - comment - 20 Sep 2023

I have tested this item ✅ successfully on 34c246c


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41825.

avatar HLeithner HLeithner - change - 20 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-20 09:09:38
Closed_By HLeithner
Labels Added: PR-5.0-dev
avatar HLeithner HLeithner - close - 20 Sep 2023
avatar HLeithner HLeithner - merge - 20 Sep 2023
avatar HLeithner
HLeithner - comment - 20 Sep 2023

thanks

avatar laoneo
laoneo - comment - 20 Sep 2023

Should this not be added into the bc plugin?

avatar HLeithner
HLeithner - comment - 20 Sep 2023

if you have a suggestion how I can move this to the b/c plugin.

I mean yes I can trigger an event or check the parameter of the plugin but not sure if this is really a good way.

I'm open for it of course I would like to move much more to the plugin, we will see if this is possible in minor versions.

Add a Comment

Login with GitHub to post a comment