Labels |
Added:
No Code Attached Yet
|
Title |
|
I am testing on Chrome and Firefox on Ubuntu 22.04 :)
I cannot reproduce it with Chrome & Firefox on Windows. Is this happening with the other settings?
for me in all tabs (chrome, windows 11)
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-20 13:19:45 |
Closed_By | ⇒ | micker |
yes confirmed for me sorry
Status | Closed | ⇒ | New |
Closed_Date | 2023-09-20 13:19:45 | ⇒ | |
Closed_By | micker | ⇒ |
Going to keep this open. @HLeithner you might want to look at bumping the asset version for that file to avoid this happening to others on upgrade. Looks like the atum override is currently pinned to the version of custom elements rather than the Joomla version. If not dark mode will bite us elsewhere at some point
which assets do you mean and where is it pinned?
The template assets version is auto, and generated with this
joomla-cms/libraries/src/Version.php
Line 255 in a71afdb
Addittionaly it regenerates every time joomla updated.
Such issue may only happen when "mediaversion refresh" is disabled in debug plugin.
Or testing on git branch, without cleaning cache ?
That's the template one. The version for the joomla-tab.css is 0.2.0 - I can't find any hardcoded reference to that so assume that comes from the version in package.json of custom-elements we use. Assume that link is buried somewhere in the build scripts
yeah, joomla-tab comes from https://www.npmjs.com/package/joomla-ui-custom-elements and version also
The JS yes. The CSS comes from this https://github.com/joomla/joomla-cms/blob/4.3-dev/build/media_source/templates/administrator/atum/scss/vendor/joomla-custom-elements/joomla-tab.scss SCSS file but is still versioned as 0.2.0 anyway in it's own file (it is NOT part of the template css files). Which is why on upgrade we're getting issues.
so maybe the logic for the version could be improved
Yes hence I've reopened this issue. Otherwise we might hit it again outside of dark mode specific issues. It's unlikely that I'll have time to work on it before the RC's though so would be amazing if someone else could pick this up. Maybe @dgrammatiko could take a look if he's not super busy ?
Since it is an override, we can also overide the asset defination,
Add:
{
"name": "webcomponent.joomla-tab",
"type": "style",
"uri": "vendor/joomla-custom-elements/joomla-tab.min.css",
},
In to Template assets administrator/templates/atum/joomla.asset.json
.
Note: The version
property is empty, it will use auto
version.
the thing is it should go automatically in auto mode for overrides?
and auto is not so cool as it sounds ;-)
Yes and no,
When you overide only file, then it will keep vendor version, defined in the asset (this case we have here)
When you overide asset with new version, then it use new version (this what the fix doing #41841)
and auto is not so cool as it sounds
Why? It pretty safe, it refreshes on every joomla update,
addittionaly when you push "clean all cache" in backend, it also will force a new media version
Why? It pretty safe, it refreshes on every joomla update,
addittionaly when you push "clean all cache" in backend, it also will force a new media version
It doesn't check the file,
Do you really want to add extra filesystem IO request ? ?
the hash is too long (unneeded traffic)
We can make it shorter, but that not really an issue, it not huge
I would like to have a "development" or "random" mode in addition
We have it: enable debug, and in debug plugin you can change "refresh every time" or "do not use it"
I think our approach is already good enough. Maybe confusing, but working ?
@Fedik could you also reduce the version string here:
joomla-cms/build/build-modules-js/versioning.es6.js
Lines 62 to 64 in 1739c46
Nevermind, here's the PR: #41844
Can we focus on the issue which is to use the Joomla version string for the css file from atum used for the tabs styling :)
Status | New | ⇒ | Closed |
Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-20 18:26:24 |
Closed_By | ⇒ | wilsonge |
I can't reproduce the tabs issue at all. I can only suggest you have some sort of template override in place or the file failed to compile somewhere as tabs customisations are in media/templates/administrator/atum/css/vendor/joomla-custom-elements/joomla-tab.min.css rather than the main template file.
The editor itself is a known issue and is captured in #41801