[#41799] - [5.0] Rework styling so it's part of SCSS not in the HTML
- Fixed in Code Base
- 19 Sep 2023
- Medium
- Build: 5.0-dev
- # 41799
- Diff
- wilsonge:refactor/html-class-to-scss
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Summary of Changes
Moves most the CSS classes in the list.php view to SCSS. This allows better control of the classes for things like color and background checks in dark mode in the future. By sticking to the BEM classes we also have better decoupling from bootstrap for any further changes in the future. Importantly all the classes I'm styling on already exist largely which makes this view very easy to convert. The only new class I've added is the one to mark the active MFA Method.
Once this is merged it then allows me to solve #41794 by removing the bg-light class from the SCSS and adding in media queries for conditional colors and backgrounds.
Testing Instructions
Check the MFA configuration renders exactly the same as it did before. There should be no differences at this point in either light or dark modes
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_users Repository NPM Change |
| Status | New | ⇒ | Pending |
| Title |
|
||||||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-19 07:59:35 |
| Closed_By | ⇒ | HLeithner | |
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
|
||
thanks, I thinks that's a good way to solve the issue.