NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
18 Sep 2023

Pull Request for Issue #41796 .

Summary of Changes

This is the better but also slightly more risky fix than I had in #41773 that should cover all these dropdowns.

Testing Instructions

Check global configuration view and validate the text is shown in dark mode in the correct color for both the text filters tab as well as global permissions tab. Check any other tabs in any of core. We use options-form as a class in many places and I can't be 100% nothing else will be impacted from this (although I've taken a quick look around and can't find anything too crazy)

Actual result BEFORE applying this Pull Request

text-filters

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 18 Sep 2023
Category Repository NPM Change
avatar wilsonge wilsonge - open - 18 Sep 2023
avatar wilsonge wilsonge - change - 18 Sep 2023
Status New Pending
avatar HLeithner HLeithner - change - 18 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-18 18:43:53
Closed_By HLeithner
Labels Added: NPM Resource Changed PR-5.0-dev
avatar HLeithner HLeithner - close - 18 Sep 2023
avatar HLeithner HLeithner - merge - 18 Sep 2023
avatar HLeithner
HLeithner - comment - 18 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment