Feeling Lucky
bug
PR-5.0-dev
[#41786] - [5.0] Better check for empty options for legacy XTD Buttons
- Fixed in Code Base
- 18 Sep 2023
- Medium
- Build: 5.0-dev
- # 41786
- Diff
- Fedik:fix-buttons-empty-options
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
A Better check for empty options for legacy XTD Buttons.
A legacy butons may have an empty options as:
$button = new CMSObject();
$button->options = '';Then ?? will not work.
Testing Instructions
Code review
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Libraries |
| Status | New | ⇒ | Pending |
| Labels |
Added:
bug
PR-5.0-dev
|
||
joeforjoomla
- comment
- 18 Sep 2023
@HLeithner Yes this works for me
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-18 12:58:23 |
| Closed_By | ⇒ | HLeithner |
HLeithner
- comment
- 18 Sep 2023
thanks
@joeforjoomla if this works for you @Fedik (or any other maintainer) can merge this