[#41778] - [5.0] Dark Mode and template parameter options & A11y
- Closed
- 24 Jul 2024
- Medium
- Build: 4.3-dev
- # 41778
We have two places in core where we make users choose options:
- The link color. This is not AA a11y compatible in Dark Mode - bootstrap itself has two separate colors for this. Do we want to give users the options to have dark and light mode
- The template 'special' color. This text is basically invisible in dark mode
Again do we want to have separate colors for this or not? It's presumably going to be hard to have a color that gives A11y compliance in both light and dark modes.
joomla-cms-bot
- | Labels |
Added:
No Code Attached Yet
|
||
@HLeithner @wilsonge I'm not convinced that there such a need for another colour. Here's my take with Muta
| Labels |
Added:
Release Blocker
|
||
I’m marking this one as a release blocker as whether we merge the color changes or not these template params need dealing with
these template params need dealing with
There's still a need to deal with the -rgb vars for these colours. In muta I'm doing it directly in the js of the field but for atum (due to b/c) there should be some update fn in the PHP to introduce these values in the db table styles. For ref: https://github.com/dgrammatiko/muta/blob/d6eb3f2f5d12700ae4d461f6fbe5d3cacf266684/media_source/templates/administrator/muta/js/dgcolor-field.mjs#L121-L130
Quy
- | Labels |
Added:
Dark Mode
|
||
Hackwar
- | Labels |
Added:
bug
|
||
| Labels |
Removed:
Release Blocker
|
||
as far as I can tell btn-secondary no longer uses the special colour
Looks like this can be closed
| Status | New | ⇒ | Closed |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2024-07-24 16:00:43 |
| Closed_By | ⇒ | wilsonge |
Different color make sense i think