NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
17 Sep 2023

Pull Request for Issue raised by @Quy in #41409 .

Summary of Changes

Removes a very odd border in media manager that was basically invisible in light mode and in dark mode looked very weird but doesn't really solve a purpose. Also solves the color of the disk name (N.B. In light mode this color changes fractionally as I've moved the text to use the text color variable rather than the background color variable).

Testing Instructions

In media manager check the border is removed. Note if you look very carefully in light mode you can also see it extending out the shaded component area too. Check the colors of the disk name

Actual result BEFORE applying this Pull Request

41409-media

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 17 Sep 2023
Category Repository NPM Change
avatar wilsonge wilsonge - open - 17 Sep 2023
avatar wilsonge wilsonge - change - 17 Sep 2023
Status New Pending
avatar wilsonge wilsonge - change - 17 Sep 2023
Labels Added: NPM Resource Changed PR-5.0-dev
avatar wilsonge wilsonge - change - 17 Sep 2023
The description was changed
avatar wilsonge wilsonge - edited - 17 Sep 2023
avatar wilsonge wilsonge - change - 17 Sep 2023
The description was changed
avatar wilsonge wilsonge - edited - 17 Sep 2023
avatar Quy Quy - test_item - 17 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 17 Sep 2023

I have tested this item ✅ successfully on f6e6fe3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41775.

avatar HLeithner HLeithner - close - 17 Sep 2023
avatar HLeithner HLeithner - merge - 17 Sep 2023
avatar HLeithner HLeithner - change - 17 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-17 16:37:29
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 17 Sep 2023

thanks

Add a Comment

Login with GitHub to post a comment