[#41772] - [5.0] Better dark mode experience for menu item type selection
- Fixed in Code Base
- 17 Sep 2023
- Medium
- Build: 5.0-dev
- # 41772
- Diff
- wilsonge:fix/dark-mode-menu-type
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue #41571 (partial) .
Summary of Changes
A improvement on the code removed here https://github.com/joomla/joomla-cms/pull/41409/files#diff-8217546eabc29ea45f71bf3257a82032411b425bf068753096719301bb30563bL3 where we overrode the theme color specific background for white in all cases for no clear reason. It seems it's only used in the menu item area. For now I've chosen to replace that with scoping it down to lists within accordions and also added some dark color themes and used the template css user selected variable for the blue link color rather than the template one which gives better theming appearances.
Testing Instructions
Check in light and dark mode. The original issue background color differences should be fixed back to how things were in 4.3/4.4. Dark mode is also improved with a darker background.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
-
Documentation link for docs.joomla.org:
-
No documentation changes for docs.joomla.org needed
-
Pull Request link for manual.joomla.org:
-
No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Repository NPM Change |
| Status | New | ⇒ | Pending |
This is already fixed in the one you merged
| Labels |
Added:
NPM Resource Changed
PR-5.0-dev
|
||
| Status | Pending | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-17 16:46:37 |
| Closed_By | ⇒ | HLeithner |
thanks
CS plz