NPM Resource Changed PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar wilsonge
wilsonge
13 Sep 2023

Pull Request for Issue raised by @Quy in the dark mode PR #41409

Summary of Changes

Fixes interactions of the calendar in dark mode

Note: Currently the SVG Icon is not color'd correctly - I'm still trying to work on a fix for that will work for templates that don't support dark mode.

Testing Instructions

Check the calendar field in light and dark mode. Light mode shouldn't be any different but should be validated in both atum and cassiopia. Dark mode should look much more native!

Actual result BEFORE applying this Pull Request

calendar

Expected result AFTER applying this Pull Request

image

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2023
Category Repository NPM Change
avatar wilsonge wilsonge - open - 13 Sep 2023
avatar wilsonge wilsonge - change - 13 Sep 2023
Status New Pending
avatar wilsonge wilsonge - change - 13 Sep 2023
Labels Added: NPM Resource Changed PR-5.0-dev
avatar wilsonge wilsonge - change - 13 Sep 2023
The description was changed
avatar wilsonge wilsonge - edited - 13 Sep 2023
avatar wilsonge wilsonge - change - 14 Sep 2023
The description was changed
avatar wilsonge wilsonge - edited - 14 Sep 2023
avatar wilsonge
wilsonge - comment - 17 Sep 2023

I've decided to open this up for testing as it's at least an improvement on how it was. The SVG color can be fixed in a further PR.

avatar wilsonge wilsonge - change - 17 Sep 2023
Title
[5.0][WIP] Fixes for calendar dark mode
[5.0] Fixes for calendar dark mode
avatar wilsonge wilsonge - edited - 17 Sep 2023
avatar Quy Quy - test_item - 17 Sep 2023 - Tested successfully
avatar Quy
Quy - comment - 17 Sep 2023

I have tested this item ✅ successfully on bdae4ca


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41743.

avatar HLeithner HLeithner - change - 17 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-17 16:47:06
Closed_By HLeithner
avatar HLeithner HLeithner - close - 17 Sep 2023
avatar HLeithner HLeithner - merge - 17 Sep 2023
avatar HLeithner
HLeithner - comment - 17 Sep 2023

thanks, created new issue for the svg

Add a Comment

Login with GitHub to post a comment