?
avatar normdouglas
normdouglas
25 Aug 2014

Steps to reproduce the issue

System template calls missing css file, namely template.css
templates/system/component.php line 17
Calls template.css which is no longer shipped with Joomla.

Expected result

Either needs to be updated and or removed.

Actual result

System information (as much as possible)

Additional comments

avatar normdouglas normdouglas - open - 25 Aug 2014
avatar Bakual
Bakual - comment - 25 Aug 2014

As far as I know that file is actually kind of a fallback which is only loaded if the active template doesn't provide an own.
Thus it may find a CSS file or not depending on the active template.

I think it's fine as it is. Whith which template did you found this being an issue? Maybe that template just needs to be fixed?

avatar normdouglas
normdouglas - comment - 25 Aug 2014

The component file is calling an unknown file... How can that be correct?

Sent from mobile.
On 25/08/2014 6:27 pm, "Thomas Hunziker" notifications@github.com wrote:

As far as I know that file is actually kind of a fallback which is only
loaded if the active template doesn't provide an own.
Thus it may find a CSS file or not depending on the active template.

I think it's fine as it is. Whith which template did you found this being
an issue? Maybe that template just needs to be fixed?

Reply to this email directly or view it on GitHub
#4174 (comment).

avatar Bakual Bakual - change - 25 Aug 2014
Status New Closed
Closed_Date 0000-00-00 00:00:00 2014-08-25 09:01:25
avatar Bakual Bakual - close - 25 Aug 2014
avatar Bakual
Bakual - comment - 25 Aug 2014

The system/component.php is only loaded if your template doesn't provide an own. I just verified. It's a generic fallback in case the template doesn't provide an own file.

Joomla uses the component.php file instead of the regular index.php file if the request contains &tmpl=component and it is supposed to only load the component output without any modules. Usually that's the case for modal windows and similar things.

Joomla then tries to first load the file from the template and if it doesn't exist it loads the system one.

The core templates all have an own component.php file and thus you shouldn't see that issue.

So it's actually working as intended. If it doesn't work for your template, you need to provide an own component.php in your template. Which you actually should do anyway.

Closing as not a bug.

avatar Bakual Bakual - close - 25 Aug 2014
avatar brianteeman
brianteeman - comment - 25 Aug 2014

@Bakual while everything you say above is perfectly correct @normdouglas is also correct tat this file has a call to include a css file that does not exist. So while it will probably never get loaded on a working site if it does then it will try to load a file that doesnt exist

avatar brianteeman brianteeman - change - 25 Aug 2014
Status Closed New
avatar brianteeman brianteeman - reopen - 25 Aug 2014
avatar brianteeman brianteeman - reopen - 25 Aug 2014
avatar normdouglas
normdouglas - comment - 25 Aug 2014

Whilst many templates may have the component file... This should only be as
an override,therefore if it's not there then the core file is called... And
hence the core file has poorly constructed code... I would respectfully
suggest that this is not ideal.

Sent from mobile.
On 25/08/2014 7:03 pm, "Brian Teeman" notifications@github.com wrote:

Reopened #4174 #4174.

Reply to this email directly or view it on GitHub
#4174 (comment).

avatar brianteeman
brianteeman - comment - 25 Aug 2014

Actually all templates should have that file but its still a bug in my opinion to call a file that doesnt exist

avatar normdouglas
normdouglas - comment - 25 Aug 2014

Thanks Brian... Saying that all templates should have it... Then should
they all have an error file also? That's the purpose of the mvc templates
over ride that was created in j.5. I expect my code to have missing file
calls and errors... I don't expect the system templates to have them... My
guess is that this template css once existed... But no longer.
Thanks for you interest mate... Great to hear from you.

Sent from mobile.
On 25/08/2014 7:31 pm, "Brian Teeman" notifications@github.com wrote:

Actually all templates should have that file but its still a bug in my
opinion to call a file that doesnt exist

Reply to this email directly or view it on GitHub
#4174 (comment).

avatar Bakual
Bakual - comment - 25 Aug 2014

The file may exist depending on the active template, or not? It doesn't look in the system folder, it looks in the active template folder.
It still would be a specific template bug imho. Not a core bug :)

----- Ursprüngliche Nachricht -----
Von: Brian Teeman
Gesendet: 25.08.2014 11:31
An: joomla/joomla-cms
Cc: Thomas Hunziker
Betreff: Re: [joomla-cms] System template calls missing css file (#4174)

Actually all templates should have that file but its still a bug in my opinion to call a file that doesnt exist


Reply to this email directly or view it on GitHub:
#4174 (comment)

avatar normdouglas
normdouglas - comment - 25 Aug 2014

Thomas... There is a line in a core file that is fundamentally incorrect.
I can't understand why you are defending this. It appears to be a legacy
line that should be removed.

Sent from mobile.
On 25/08/2014 7:42 pm, "Thomas Hunziker" notifications@github.com wrote:

The file may exist depending on the active template, or not? It doesn't
look in the system folder, it looks in the active template folder.
It still would be a specific template bug imho. Not a core bug :)

----- Ursprüngliche Nachricht -----
Von: Brian Teeman
Gesendet: 25.08.2014 11:31
An: joomla/joomla-cms
Cc: Thomas Hunziker
Betreff: Re: [joomla-cms] System template calls missing css file (#4174)

Actually all templates should have that file but its still a bug in my
opinion to call a file that doesnt exist


Reply to this email directly or view it on GitHub:
#4174 (comment)

Reply to this email directly or view it on GitHub
#4174 (comment).

avatar brianteeman
brianteeman - comment - 25 Aug 2014

I will create a pull request to remove it shortly
On 25 Aug 2014 10:47, "normdouglas" notifications@github.com wrote:

Thomas... There is a line in a core file that is fundamentally incorrect.
I can't understand why you are defending this. It appears to be a legacy
line that should be removed.

Sent from mobile.
On 25/08/2014 7:42 pm, "Thomas Hunziker" notifications@github.com
wrote:

The file may exist depending on the active template, or not? It doesn't
look in the system folder, it looks in the active template folder.
It still would be a specific template bug imho. Not a core bug :)

----- Ursprüngliche Nachricht -----
Von: Brian Teeman
Gesendet: 25.08.2014 11:31
An: joomla/joomla-cms
Cc: Thomas Hunziker
Betreff: Re: [joomla-cms] System template calls missing css file (#4174)

Actually all templates should have that file but its still a bug in my
opinion to call a file that doesnt exist


Reply to this email directly or view it on GitHub:
#4174 (comment)

Reply to this email directly or view it on GitHub
#4174 (comment).


Reply to this email directly or view it on GitHub
#4174 (comment).

avatar brianteeman
brianteeman - comment - 25 Aug 2014

closing in favour of #4177 to keep the conversation in one place

avatar brianteeman brianteeman - change - 25 Aug 2014
Status New Closed
Closed_Date 2014-08-25 09:01:25 2014-08-25 10:10:19
avatar brianteeman brianteeman - close - 25 Aug 2014
avatar zero-24 zero-24 - close - 25 Aug 2014
avatar brianteeman brianteeman - close - 25 Aug 2014
avatar Bakual
Bakual - comment - 25 Aug 2014

I assumed the code tries to load the css file in the (in theory) active template, but apparently it does reference it in the system folder. So removing the lines is indeed fine. Sorry for the confusion then.

The template.css was indeed present in Joomla 1.5 and got removed in 2.5.

avatar zero-24 zero-24 - change - 7 Jul 2015
Labels Added: ?

Add a Comment

Login with GitHub to post a comment