PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar richard67
richard67
13 Sep 2023

Pull Request for Issue # .

Summary of Changes

This pull request (PR) adapts the update SQL script "5.0.0-2023-07-29.sql" so that the compatibility plugin is only inserted when it does not already exist.

In addition, it adds default values to the $this->params->get calls so that class aliases and ES5 assets are enabled when the parameters in database are empty, which will be the case when updating from a future 4.4.0 version where PR #41738 is included.

The changes in PR #41738 for 4.4-dev and this PR here for 5.0-dev are made in order to handle the exception which you get when updating from 4.4 to 5.0 and having a system plugin installed and enabled which descends from JPlugin.

Testing Instructions

Test 1: Update from a 4.4 where PR #41738 is included

  1. Execute "Test 2" or "Test 3" from the testing instructions of PR #41738 , but do not install the testing plugin "ttest2.zip".

Result: Without this PR here, the compat plugin would be inserted a 2nd time. With this PR, the compat plugin is not inserted a 2nd time.

Test 2: Update from a 4.4 where PR #41738 is not included

  1. Update a current 4.0-dev or latest 4.0 nightly build or 4.4.0-alpha4 to 5.0.

Result: The compat plugin is inserted with this PR as well as without.

Test 3: Update from a 5.0.0-alpha3 or older 5.0.0-alpha where the compatibility plugin is a system plugin.

  1. Update a 5.0.0-alpha3 or older 5.0.0-alpha to 5.0.

Result: The compat plugin is inserted as a behaviour plugin with this PR as well as without, and the compat plugin as a system plugin is removed.

Actual result BEFORE applying this Pull Request

When updating from a 4.4 where PR #41738 is included, the compat plugin is inserted a 2nd time.

Expected result AFTER applying this Pull Request

When updating from a 4.4 where PR #41738 is included, the compat plugin is not inserted a 2nd time.

Any other case works as well as before, i.e. the plugin is inserted.

Link to documentations

Please select:

  • No documentation changes for docs.joomla.org needed

  • No documentation changes for manual.joomla.org needed

avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2023
Category SQL Administration com_admin Postgresql
avatar richard67 richard67 - open - 13 Sep 2023
avatar richard67 richard67 - change - 13 Sep 2023
Status New Pending
avatar richard67 richard67 - change - 13 Sep 2023
Title
Handle plugin already existing in 4.4.0 when updating
[5.0] Handle compat plugin already existing in 4.4.0 when updating
avatar richard67 richard67 - edited - 13 Sep 2023
avatar richard67 richard67 - change - 13 Sep 2023
Title
[5.0] Handle compat plugin already existing in 4.4.0 when updating
[5.0] Handle compat plugin already existing in 4.4.0 when updating to 5
avatar richard67 richard67 - edited - 13 Sep 2023
avatar richard67 richard67 - change - 13 Sep 2023
Labels Added: PR-5.0-dev
avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2023
Category SQL Administration com_admin Postgresql SQL Administration com_admin Postgresql Front End Plugins
avatar richard67 richard67 - change - 13 Sep 2023
The description was changed
avatar richard67 richard67 - edited - 13 Sep 2023
avatar richard67 richard67 - change - 13 Sep 2023
The description was changed
avatar richard67 richard67 - edited - 13 Sep 2023
avatar richard67 richard67 - change - 13 Sep 2023
The description was changed
avatar richard67 richard67 - edited - 13 Sep 2023
avatar richard67 richard67 - change - 13 Sep 2023
The description was changed
avatar richard67 richard67 - edited - 13 Sep 2023
avatar richard67 richard67 - change - 13 Sep 2023
The description was changed
avatar richard67 richard67 - edited - 13 Sep 2023
avatar richard67 richard67 - change - 13 Sep 2023
The description was changed
avatar richard67 richard67 - edited - 13 Sep 2023
avatar HLeithner HLeithner - close - 13 Sep 2023
avatar HLeithner HLeithner - merge - 13 Sep 2023
avatar HLeithner HLeithner - change - 13 Sep 2023
Status Pending Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 2023-09-13 16:00:15
Closed_By HLeithner
avatar HLeithner
HLeithner - comment - 13 Sep 2023

Thanks

Add a Comment

Login with GitHub to post a comment