[#41734] - [4.3] Fix untranslated constants in script.php
- Fixed in Code Base
- 13 Sep 2023
- Medium
- Build: 4.3-dev
- # 41734
- Diff
- Fedik:fix-script-string
- Pending continuous-integration/drone/pr Build is pending Details
User tests: Successful: Unsuccessful:
Pull Request for Issue # .
Summary of Changes
Follow up for #41367
Replace untranslated constants to text
Testing Instructions
Code review,
Or do Test 7 from @richard67 instruction #41367 (comment)
Actual result BEFORE applying this Pull Request
Untranslated lang constant
Expected result AFTER applying this Pull Request
A fixed text
Link to documentations
Please select:
- Documentation link for docs.joomla.org:
- No documentation changes for docs.joomla.org needed
- Pull Request link for manual.joomla.org:
- No documentation changes for manual.joomla.org needed
joomla-cms-bot
- | Category | ⇒ | Administration com_admin |
| Status | New | ⇒ | Pending |
How that need to be done?
tbh I have no idea how to deprecate a text strings ?
How that need to be done? tbh I have no idea how to deprecate a text strings ?
@Fedik You move the strings to the end and add a comment about deprecation before them, like you can see it here in 5.0-dev: https://github.com/joomla/joomla-cms/blob/5.0-dev/administrator/language/en-GB/plg_system_privacyconsent.ini#L29-L44
For the "language/en-GB/files_joomla.sys.ini" it would result in following content:
; Joomla! Project
; (C) 2010 Open Source Matters, Inc. <https://www.joomla.org>
; License GNU General Public License version 2 or later; see LICENSE.txt
; Note : All ini files need to be saved as UTF-8
FILES_JOOMLA="Joomla CMS"
FILES_JOOMLA_XML_DESCRIPTION="Joomla! 4 Content Management System."
; All the following strings are deprecated and will be removed with 6.0
FILES_JOOMLA_ERROR_FILE_FOLDER="Error on deleting file or folder %s"
FILES_JOOMLA_ERROR_MANIFEST="Error on updating manifest cache: (type, element, folder, client) = (%s, %s, %s, %s)"
@HLeithner Would it also need to add the language string deprecation to some developer documentation?
| Category | Administration com_admin | ⇒ | Administration com_admin Language & Strings |
| Labels |
Added:
bug
PR-4.3-dev
|
||
Done
I have tested this item ✅ successfully on ca14692
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41734.
I have tested this item ✅ successfully on ca14692
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41734.
| Status | Pending | ⇒ | Ready to Commit |
RTC
This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41734.
obuisard
- | Status | Ready to Commit | ⇒ | Fixed in Code Base |
| Closed_Date | 0000-00-00 00:00:00 | ⇒ | 2023-09-13 13:28:57 |
| Closed_By | ⇒ | obuisard | |
| Labels |
Added:
?
Language Change
|
||
@Fedik As the 2 language strings "FILES_JOOMLA_ERROR_MANIFEST" and "FILES_JOOMLA_ERROR_FILE_FOLDER" will not be used anymore with your PR, could you deprecate them in file "language/en-GB/files_joomla.sys.ini"?