Joomla! Issue Tracker - CMS

Download
Launch
Feeling Lucky

[#41732] - [5.0] Fix com_ajax event with webauthn plugin, take2

bug PR-5.0-dev Pending

User tests: Successful: Unsuccessful:

avatar Fedik
Fedik
13 Sep 2023

Pull Request for Issue #41719 .

Summary of Changes

Alternative for #41720

Testing Instructions

Please follow #41719

Actual result BEFORE applying this Pull Request

error

Expected result AFTER applying this Pull Request

works

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:
  • No documentation changes for docs.joomla.org needed
  • Pull Request link for manual.joomla.org:
  • No documentation changes for manual.joomla.org needed
avatar joomla-cms-bot joomla-cms-bot - change - 13 Sep 2023
Category ⇒ Front End com_ajax Libraries Plugins
avatar Fedik Fedik - open - 13 Sep 2023
avatar Fedik Fedik - change - 13 Sep 2023
Status New ⇒ Pending
avatar Fedik
Fedik - comment - 13 Sep 2023

@heelc29 please test this alternative, it should be better, in theory

20d7a19 13 Sep 2023 avatar Fedik phpcs
avatar Fedik Fedik - change - 13 Sep 2023
Labels Added: bug PR-5.0-dev
avatar heelc29 heelc29 - test_item - 13 Sep 2023 - Tested successfully
avatar heelc29
heelc29 - comment - 13 Sep 2023

I have tested this item ✅ successfully on 20d7a19

This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/41732.

avatar HLeithner
HLeithner - comment - 13 Sep 2023

this makes the Event Classes provided by the plugin obsolete right? Should we remove them and/or deprecated them?

avatar Fedik
Fedik - comment - 13 Sep 2023

No no, they in use

joomla-cms/plugins/system/webauthn/src/PluginTraits/AjaxHandler.php

Lines 87 to 114 in 20d7a19

switch ($eventName) {
case 'onAjaxWebauthn':
$eventClass = PlgSystemWebauthnAjax::class;
break;
case 'onAjaxWebauthnChallenge':
$eventClass = PlgSystemWebauthnAjaxChallenge::class;
break;
case 'onAjaxWebauthnCreate':
$eventClass = PlgSystemWebauthnAjaxCreate::class;
break;
case 'onAjaxWebauthnDelete':
$eventClass = PlgSystemWebauthnAjaxDelete::class;
break;
case 'onAjaxWebauthnInitcreate':
$eventClass = PlgSystemWebauthnAjaxInitCreate::class;
break;
case 'onAjaxWebauthnLogin':
$eventClass = PlgSystemWebauthnAjaxLogin::class;
break;
case 'onAjaxWebauthnSavelabel':
$eventClass = PlgSystemWebauthnAjaxSaveLabel::class;
break;

avatar HLeithner HLeithner - change - 13 Sep 2023
Status Pending ⇒ Fixed in Code Base
Closed_Date 0000-00-00 00:00:00 ⇒ 2023-09-13 16:09:12
Closed_By ⇒ HLeithner
avatar HLeithner HLeithner - close - 13 Sep 2023
avatar HLeithner HLeithner - merge - 13 Sep 2023
avatar HLeithner
HLeithner - comment - 13 Sep 2023

ok I think then this is a better version. thanks

Add a Comment

Login with GitHub to post a comment